-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix corner cases of wb_dims + standardize error messages #990
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks like this is good to go
Thanks! Hope the code is clear for you. I feel like we have come a long way since #702. I feel like you are starting to like |
It’s perfectly fine! And yes, we sure have. And if I think of The only thing I’m constantly sad about is that we’re still not able to select dims as freely as I want. I like to see a system where it’s possible to have various independent cells. Like But we’ll see, Rome wasn’t built in a day. Soon we’ll see the 1000th issue, PR or discussion. Wouldn’t imagine that when I started |
I agree, but at least we have a solid foundation, we know we can trust the results, and won't be able worried to break existing code when we extend it. |
Addresses #988 (comment)
Doing some touchups locally!