Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v12.4.0 is broken on Node 18 #237

Closed
ColinCee opened this issue Jul 31, 2024 · 4 comments
Closed

v12.4.0 is broken on Node 18 #237

ColinCee opened this issue Jul 31, 2024 · 4 comments
Labels
Type: Test

Comments

@ColinCee
Copy link

Description

  1. Use node 18.19.0
  2. Try to install syncpack yarn install syncpack
  3. Get error: error [email protected]: The engine "node" is incompatible with this module. Expected version "20 || >=22". Got "18.19.0"

Suggested Solution

  1. Revert to minimatch v9
  2. Considering this is a breaking change this should probably be a major version no?
@JamieMason
Copy link
Owner

Thanks @ColinCee,
The 12.4.0 tag passed CI on Node.js 18.x so I wasn't aware. That is using pnpm, I can look at adding other CI jobs to check installation with other package managers, to see if that would catch engines regressions in the future.

@ColinCee
Copy link
Author

Thanks Jamie, very interesting that pnpm is passing whilst yarn isn't.

Note the project I'm working on is using yarn v1 which I know is not ideal

@JamieMason
Copy link
Owner

It's all good, a lot of people still use Yarn v1 – I still have it on a lot of projects.

JamieMason added a commit that referenced this issue Aug 25, 2024
@JamieMason
fix(engines): ensure correct required node version
e8df803 
Closes #237

BREAKING CHANGE:

Changed `engines.node` from `>=16` to `>=18.18.0`.

`minimatch@10` was updated in `[email protected]` which required `node@>=20` and
caused issues in some projects.

This change adds a local linter to verify that the node engines of syncpack's
dependencies all satisfy syncpack's own node engine. Using this linter found
that the minimum node engine of all of syncpack's dependencies is v18.18.0.
@JamieMason
Copy link
Owner

Hopefully fixed in 13.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JamieMason @ColinCee