Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support (or at least non-fatal handling) for git dependencies? #19

Closed
thedewi opened this issue Mar 29, 2016 · 5 comments
Closed

Support (or at least non-fatal handling) for git dependencies? #19

thedewi opened this issue Mar 29, 2016 · 5 comments

Comments

@thedewi
Copy link

thedewi commented Mar 29, 2016

Git dependencies are causing fatal errors on my system.

My npm-shrinkwrap.json contains this github dependency entry:

"techan": {
  "version": "0.6.0",
  "from": "techan@git://github.com/andredumas/techan.js#f7d1489b61a2dd951036f9dc207d1c91339b00f9",
  "resolved": "git://github.com/andredumas/techan.js#f7d1489b61a2dd951036f9dc207d1c91339b00f9"
},

This derives from my package.json entry: "techan": "andredumas/techan.js#0.6.0"

Shrinkpack (or maybe it's npm's cache API) doesn't seem to know how to respond:

error adding [email protected] to npm cache: Error: Registry returned 404 for GET on https://registry.npmjs.org/techan
Please raise an issue at https://github.com/JamieMason/shrinkpack/issues

    TypeError: Cannot read property 'npm' of undefined
        at Object.addPackage (D:\dev\apps\GeonomicsCarbonSim\deploy\WebRoot\node_modules\shrinkpack\src\shrinkpack.js:24:33)
        at addToShrinkpack (D:\dev\apps\GeonomicsCarbonSim\deploy\WebRoot\node_modules\shrinkpack\index.js:117:27)
        at tryCatchReject (D:\dev\apps\GeonomicsCarbonSim\deploy\WebRoot\node_modules\shrinkpack\node_modules\when\lib\makePromise.js:845:30)
        at runContinuation1 (D:\dev\apps\GeonomicsCarbonSim\deploy\WebRoot\node_modules\shrinkpack\node_modules\when\lib\makePromise.js:804:4)
        at Fulfilled.when (D:\dev\apps\GeonomicsCarbonSim\deploy\WebRoot\node_modules\shrinkpack\node_modules\when\lib\makePromise.js:592:4)
        at Pending.run (D:\dev\apps\GeonomicsCarbonSim\deploy\WebRoot\node_modules\shrinkpack\node_modules\when\lib\makePromise.js:483:13)
        at Scheduler._drain (D:\dev\apps\GeonomicsCarbonSim\deploy\WebRoot\node_modules\shrinkpack\node_modules\when\lib\Scheduler.js:62:19)
        at Scheduler.drain (D:\dev\apps\GeonomicsCarbonSim\deploy\WebRoot\node_modules\shrinkpack\node_modules\when\lib\Scheduler.js:27:9)
        at process._tickCallback (node.js:419:13)
@JamieMason
Copy link
Owner

Thanks for raising this, I'll get a fix sorted soon.

@JamieMason
Copy link
Owner

Got this working locally.

@DylanPiercey
Copy link
Contributor

Will this fix scoped repos?

@JamieMason
Copy link
Owner

Version 0.5.0 has been released, please could you give it a try and update or close this issue?

Thanks a lot @thedewi @DylanPiercey

@JamieMason JamieMason added bug and removed bug labels Apr 3, 2016
@JamieMason
Copy link
Owner

Closing just as part of issue housekeeping, please re-open if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants