Skip to content
This repository has been archived by the owner on Jan 14, 2019. It is now read-only.

BREAKING: add missing TSImportEqualsDeclaration node #71

Merged
merged 1 commit into from
Jan 1, 2019
Merged

BREAKING: add missing TSImportEqualsDeclaration node #71

merged 1 commit into from
Jan 1, 2019

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Dec 29, 2018 •
edited
Loading

This PR contains breaking change and requires that #70 is merged first.

  • Add missing node type TSImportEqualsDeclaration and TSExternalModuleReference
  • Add test cases

changes to AST:

  • TSImportEqualsDeclaration
    • new property isExport instead of modifiers
    • property name got renamed to id

@armano2
Copy link
Contributor Author

armano2 commented Dec 29, 2018 •
edited
Loading

tests are failing due to:

- "type": "Literal",
+ "type": "StringLiteral",

and it got solved by #70

@armano2 armano2 changed the title feat: add support for export equal declaration. BREAKING: add support for export equal declaration. Dec 31, 2018
@armano2 armano2 changed the title BREAKING: add support for export equal declaration. BREAKING: add missing TSImportEqualsDeclaration node Dec 31, 2018
@armano2 armano2 mentioned this pull request Dec 31, 2018
Open
JamesHenry
JamesHenry reviewed Jan 1, 2019
View reviewed changes
Copy link
Owner

@JamesHenry JamesHenry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does babel use isExport, or did you create that? It's a shame if they do, cause that doesn't really fit with other boolean property names in ESTree...

@armano2
Copy link
Contributor Author

armano2 commented Jan 1, 2019

@JamesHenry they are doing this in this way, i don't like this either...

@JamesHenry
Copy link
Owner

Cool, thanks for digging into it!

JamesHenry
JamesHenry previously approved these changes Jan 1, 2019
View reviewed changes
@JamesHenry JamesHenry merged commit 7827666 into JamesHenry:master Jan 1, 2019
@armano2 armano2 deleted the export-equal branch January 1, 2019 20:37
@JamesHenry
Copy link
Owner

🎉 This PR is included in version 9.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@armano2 armano2 mentioned this pull request Jan 1, 2019
Closed
@armano2 armano2 mentioned this pull request Jan 12, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @JamesHenry