Frontend: Polish kanban task #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susulone
reviewed
Feb 16, 2024
susulone
reviewed
Feb 16, 2024
susulone
pushed a commit
that referenced
this pull request
Feb 19, 2024
* Polish kanban task * Fix disappearing members * Change member limits * Scale kanban deadline buttons * Add suggested fixes
Moiman
added a commit
that referenced
this pull request
Feb 19, 2024
* Modal: remove unnecessary comments * Modal: remove dialog from the tab index * Modal: give all focusable children a tab index and make them loop * DeleteModal: Remove dialog from the tab index. Give all focusable children a tab index and make them loop. Add event listener to be able to close modal with esc. * DeleteModal: add aria label to close modal button * SubModal: Remove dialog from the tab index. Give all focusable children a tab index and make them loop. Add event listener to be able to close modal with esc. * SubModal: add aria labels for icon buttons * SubModal: wrap closeAllModals with use callback hook * Modal: remove aria modal * CreateLabelModal: change import to import type * changed modal to close on mouse dow * Frontend: Kanban column polish (#167) * Polish kanban column layout * Fix button position * Add padding to show full outline * Change height to avoid column warping on drag * Fix height * Adjust task positions * Add missing tabIndex and onKeyDown to TaskMemberItem (#168) * Password update validation (#166) * removed couple comments and added backend password update validation * Type fix * fixes * KanbanTask: Remove dialog from the tab index. Give all focusable children a tab index and make them loop. Add event listener to be able to close modal with esc and add aria label for the close task button. * CreateLabelModal: add autofocus for the input field * EditLabelModal: add autofocus for the input field * KanbanTask: change closing the task modal to onMouseDown * SubModal: change closing the modal to onMouseDown * IconButton: fix sizing issues when only icon is displayed * LabelModal: make checkbox focusable and selectable with keyboard * LabelModal: refactor code to be able to select the task by clicking the task name also * SubModal: change min-w-[400px] to only apply with larger screens * LabelModal: give label modal a max height and give overflow a scroll * TaskMembersModal: give modal a max height and set overflow to scroll * Modal: remove unnecessary styling from the dialog and change overflow to hidden * ProjectMembersModal: give div a max height and set overflow to auto * SubModal: remove unnecessary styling from the dialog * DeleteEventModal: refactor button to enable better styling * CalendarEventModal: Remove dialog from the tab index. Give all focusable children a tab index and make them loop. Add listener to be able to close modal with esc and add aria label for the close modal button. * make suggested fixes to LabelModal and TaskMemberItem * fix overflow issues in horizontal mobile screens * fix overflow issues in horizontal mobile screens * DeleteModal: fix issues on vertical mobile screen * fix overflow issues in horizontal mobile screens (Modal) * frontend: pass only required events to eventmodal * frontend: calendar change from y.array to y.map * frontend: increase event maxlength (#170) * frontend: invalidate projects cache on userUpdate * frontend: update backend url * Frontend: Polish kanban task (#173) * Polish kanban task * Fix disappearing members * Change member limits * Scale kanban deadline buttons * Add suggested fixes * KanbanTask: Remove dialog from the tab index. Give all focusable children a tab index and make them loop. Add event listener to be able to close modal with esc and add aria label for the close task button. * KanbanTask: fix deadline label styling * Modal: change overflow-y-hidden to auto * ProjectMembersModal: change max height --------- Co-authored-by: Tyni <[email protected]> Co-authored-by: Katariina Ruotsalainen <[email protected]> Co-authored-by: TTyni <[email protected]> Co-authored-by: Harri Nieminen <[email protected]> Co-authored-by: Harri Nieminen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes