chore(monorepo): separate each loader into its own package

[JakobJingleheimer]

closes #19

[AugustinMauroy]

Feedback

• Use 22 in .nvmrc to use LTS
• Update dep to just have @types/nodejs because we don't need specific packages.

Is .npmignore still need ?

Out of date

[JakobJingleheimer]

• Use 22 in .nvmrc to use LTSpackages.

I added backport requests to module.findPackageJSON(). I'm not sure if those will happen immediately. It will be available in 23.2 though.

• Update dep to just have @types/nodejs because we don't need specific

I don't understand—isn't that what I did? (The package is @types/node btw)

Is .npmignore still need ?

Yes, very much: That's what prevents dev files getting published.

[JakobJingleheimer]

@AugustinMauroy I added some commits on top of a WIP commit. I'll finish my WIP commit, then cherry-pick your stuff back on top, and then force-push.

[AugustinMauroy]

I don't understand—isn't that what I did? (The package is @types/node btw)

yup my bad I didn't see you remove it from sub packages

[AugustinMauroy]

I added backport requests to nodejs/node#55412. I'm not sure if those will happen immediately. It will be available in 23.2 though.

is it mean loader will only work for 23.2 ??? (for example nodejs.org still on 20)

[JakobJingleheimer]

is it mean loader will only work for 23.2 ??? (for example nodejs.org still on 20)

For tsx loader, unfortunately yes (until node:module.findPackageJSON() gets backported, which may be right away). I can't think of another way to find esbuild.config. Would love another idea! (we can't use process.cwd()).

As-is, we can't release this change until findPackageJSON is released.

EDIT: I spoke with Antoine, and 23.2 is being prepared now, then it will be backported to 22.x and 20.x 2 weeks later. So let's target Mon, 25 November for the nodejs-loaders v2 release.

[AugustinMauroy]

now we can put in gitignore because we publish it with GA

[JakobJingleheimer]

I'm not sure: I committed it because a comment is supposed to get posted with a coverage diff. I think in order to do that, coverage needs to get committed?

[AugustinMauroy]

Honslty I'm not sure. It's first time I work on a package. But with jest we didn't commit the coverage.

[AugustinMauroy]

LGTM ! Just one remaining thing should we merge before back port or wait backport.
Or merge but wait for publishing.
Any strong opinions

[AugustinMauroy]

WOW happy to see this happened !