Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

Close the app when back is pressed with keyboard opened and search field is empty #133

Open
bernaferrari opened this issue Oct 2, 2018 · 5 comments

Comments

@bernaferrari
Copy link
Contributor

I'm not sure how SDK Search is going to be in the future, but right now, I think it makes sense to kill the app when user press back, the keyboard is opened and the search field is empty.
If the back is pressed, the user probably wants to exit the app, since there is no addional functionality.

There are apps like Chrome that already do this to some extent, for example, by automatically closing the omnibox fragment when user press back and the keyboard is opened.

@JakeWharton JakeWharton changed the title [Suggestion] Close the app when back is pressed with keyboard opened and search field is empty Close the app when back is pressed with keyboard opened and search field is empty Dec 15, 2018
@JakeWharton
Copy link
Owner

Sounds good. PR welcome for this.

@mohammaddvi
Copy link

Hi, can i work on this issue?Is it open yet?

@JakeWharton
Copy link
Owner

JakeWharton commented Mar 11, 2020 via email

@mohammaddvi
Copy link

Hi again, After some thinking about this enhancement I find out this is a bad UX and detecting keyboard visibility is some boilerplate code that not necessary. If you are not agree let me know to implement this enhancement.

@dfresh806
Copy link

dfresh806 commented Mar 13, 2020 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants