Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es6-promise is not a safe polyfill to recommend in your readme #415

Closed
nilliams opened this issue Oct 21, 2016 · 3 comments
Closed

es6-promise is not a safe polyfill to recommend in your readme #415

nilliams opened this issue Oct 21, 2016 · 3 comments

Comments

@nilliams
Copy link

nilliams commented Oct 21, 2016

See exact same issue raised here: matthew-andrews/isomorphic-fetch#111

Make sure you don't skip the arguably worse examples here: matthew-andrews/isomorphic-fetch#111 (comment)

@dgraham
Copy link
Contributor

dgraham commented Oct 21, 2016

We recommend that polyfill because we've been using it successfully in production for a few years. Keep in mind that the Promise polyfill is active only in IE. All other browsers provide a native implementation that disables the polyfill code.

That specific Promise library is not a requirement to use the fetch polyfill. Any other Promise implementation is fine. But we can only recommend libraries we have production experience with.

@dgraham dgraham closed this as completed Oct 21, 2016
@nilliams
Copy link
Author

nilliams commented Oct 22, 2016

Understood and to be clear, the last time I looked that up that was not the case, I believe the polyfill used to be applied in all browsers, even if they had a native implementation, otherwise I would have only hit this error in CI, which wasn't how I remember it.

However I just tried to replicate the demonstrated problems, in Chrome, with exact usage example of how you'd use it with fetch and could not, so I think you're correct there.

Still, IE usage is not insignificant for most sites, so I still think this is going to cause people problems, and it's a shame to see it closed so quickly.

@mislav
Copy link
Contributor

mislav commented Oct 23, 2016

We recommend that polyfill because we've been using it successfully in production for a few years.

It's also worth noting that we've been using es-promise 1.0.0 all this time because of that project's careless release process around 2.0.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants