feat: Implement tool to run provisioning script #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsinovassin
requested changes
Feb 19, 2025
Janin-Michel-Mathias
force-pushed
the
BACKLOG-23201
branch
from
b9289c1 to
65ed506
Compare
jsinovassin
requested changes
Feb 24, 2025
| cy.reload(); | ||
| getStartedModulesVersion().then(modules => { | ||
| console.log(modules.map(module => module.id).filter(module => /^s.*$/.test(module))); | ||
| expect(modules.some(module => module.id === 'skins')).to.be.true; |
There was a problem hiding this comment.
It would be better to check also the version of the module which is started to be sure that it the version of the module that we installed with the provisioning.
| cy.waitUntil(() => cy.get('#provisioningMessage').should('not.be.visible')); | ||
| cy.get('#provisioningResult').should('be.visible').should('not.be.empty'); | ||
| // eslint-disable-next-line cypress/no-unnecessary-waiting | ||
| cy.wait(5000); |
There was a problem hiding this comment.
Maybe a waitUntil would be better here, you should be able to call getStartedModulesVersion until you get the required module in the expected version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement tool to run provisioning script
...
Tests
The following are included in this PR
Checklist
I have considered the following implications of my change:
Documentation