Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BACKLOG-23323 Improvements to the background jobs page #136

Merged
merged 1 commit into from
Dec 17, 2024
Merged

BACKLOG-23323 Improvements to the background jobs page #136

merged 1 commit into from
Dec 17, 2024

Conversation

r3dm1ke
Copy link
Contributor

@r3dm1ke r3dm1ke commented Dec 17, 2024 •
edited
Loading

Description

This PR improved on the bg jobs page:

  • Refresh button
  • Persist pagination/sorting when switching between tabs
  • Capitalization of tab titles
  • User key parsing/ missing user keys in cloud
  • Permissions
  • Duration column wider

Tests

The following are included in this PR

  • Unit Tests (Most changes should have unit tests)
  • Integration Tests

Checklist

I have considered the following implications of my change:

  • Security (in particular for changes to authentication, authorization, data fetching, ...)
  • Performance
  • Migration
  • Code maintainability

Documentation

  • Inline documentation
  • Internal Documentation (wiki)
  • User-facing Documentation

@r3dm1ke r3dm1ke force-pushed the BACKLOG-23323-fixes branch from 880aa5f to d727ab0 Compare December 17, 2024 12:26
@r3dm1ke r3dm1ke requested a review from a team December 17, 2024 13:22
@r3dm1ke r3dm1ke force-pushed the BACKLOG-23323-fixes branch from d727ab0 to e1de4f0 Compare December 17, 2024 16:35
@r3dm1ke r3dm1ke merged commit 9903a26 into master Dec 17, 2024
6 of 7 checks passed
@r3dm1ke r3dm1ke deleted the BACKLOG-23323-fixes branch December 17, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gflores-jahia gflores-jahia gflores-jahia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r3dm1ke @gflores-jahia