MOON-338: Add component CardSelector #460
Open
+693
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate disabled & cardActions
…bnail with image & icon
…bnail props, add aria attributes
gflores-jahia
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
For reference this is the jcontent-specific implementation from the old design system https://github.com/Jahia/jcontent/blob/master/src/javascript/ContentEditor/DesignSystem/ReferenceCard/ReferenceCard.jsx
It looks like this has support for most of the information that's currently included in it, with a small comment regarding EmptyCardSelector.
| onClick={e => handleOnClick(e)} | ||
| {...props} | ||
| > | ||
| {label && <Typography className={clsx('moonstone-emptyCardSelector_label')}>{label}</Typography>} |
There was a problem hiding this comment.
From jcontent usage, looks like we make use of both icon and label for the empty card display. Is it possible to have them here as well? https://github.com/Jahia/jcontent/blob/master/src/javascript/ContentEditor/DesignSystem/ReferenceCard/ReferenceCard.jsx#L195-L200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
https://jira.jahia.org/browse/MOON-338
Description
Add components
CardSelector&EmptyCardSelectorComponent
CardSelectorhas dragging icon enabled withisDraggableprop but is not currently handling dragging