Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BACKLOG-21378: Update the Group ID to use the community one #15

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

rknj
Copy link
Contributor

@rknj rknj commented Jan 3, 2024

JIRA

https://jira.jahia.org/browse/BACKLOG-21378

Description

The goal is to higlight in the code the fact that this is a community module and to prevent the need to update the signature

@rknj rknj requested review from cedmail, fpral and Fgerthoffert January 3, 2024 14:38
Copy link
Member

@cedmail cedmail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also change this

<bean id="ChannelExclusionFilter" class="org.jahia.modules.channels.filters.ChannelExclusionFilter">

@rknj rknj requested a review from cedmail January 3, 2024 14:59
@rknj rknj merged commit 603b6ff into master Jan 3, 2024
4 checks passed
@rknj rknj deleted the BACKLOG-21378-groupid branch January 3, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants