BACKLOG-16810: Return empty query result on incompatible criteria #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarQube Quality Gate
|
AKarmanov
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
https://jira.jahia.org/browse/BACKLOG-16810
Description
From this PR, we needed a way to prevent NPE exceptions when a searchCriteria doesn't map to LDAP properties. However, returning an empty Properties object causes the query to return all results. So we need a way to prevent NPE result but also return an empty result.
Proposed fix is that if a searchCriteria doesn't map to LDAP properties, we then instead create a valid query that returns an empty result (i.e. limit result size to 0). This avoids returning null that can cause null pointer exceptions, and returns a valid query that returns an empty result as before.