-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new c++ node offboard example #7
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ecuashungo Thanks for the great contribution, and sorry for the late review.
I think looks good overall, but I think it would be great if we can be more consistent with the package naming and directory structure.
Would it be possible to merge the packages into one package and maybe make the cpp build optional? Happy to discuss if you have any opinions.
We can also just merge this PR in and improve incrementally if you prefer it this way
Co-authored-by: JaeyoungLim <[email protected]>
@Jaeyoung-Lim thanks for the review, glad I can contribute to the PX4 community. What do you suggest with respect to the naming and directory structure? What would be the advantage of merging both the python node and the c++ node into the same package? With the packages separated, a user could add a One other thought: |
Hello and thanks for your contribution, I tested the cpp version and faced the issue you mentioned in the Troubleshooting part of the ReadMe : the offboard control mode won't be applied to the SITL version of PX4. If I use the |
@TheotimeBalaguer There should be no problem with sending a switch mode command with mavlink. How are you sending this mavlink command? |
I am using this function, which send an |
@TheotimeBalaguer That is not related to |
You are right my bad ! I guess it has something to do with |
I have moved all python-related content to a separate package and created a parallel c++-package.
Instructions on how to use it are in a nested README.md