Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set long expiration when last.fm doesn't have the duration for a song #16

Closed
JackCuthbert opened this issue Nov 29, 2019 · 2 comments
Closed

Set long expiration when last.fm doesn't have the duration for a song #16

JackCuthbert opened this issue Nov 29, 2019 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers released

Comments

@JackCuthbert
Copy link
Owner

If a song doesn't have a duration stored in Last.fm then the last song you listen to for the day won't be unset. To resolve this, set a long default duration when setting the slack status.
@JackCuthbert JackCuthbert added bug Something isn't working good first issue Good for newcomers labels Nov 29, 2019
@JackCuthbert
Copy link
Owner Author

In addition to this, the #5 issue would help with solving this. Right now as the application loop updates a status every minute meaning the expiration (if it has one) moves a minute every minute until the next song comes on. Oops.

JackCuthbert added a commit that referenced this issue Dec 2, 2019
@JackCuthbert
perf: adds cache to reduce api requests
8448c68 
Fixes #16, resolves #5
JackCuthbert added a commit that referenced this issue Dec 2, 2019
@JackCuthbert
perf: adds cache to reduce api requests
9fc5862 
Fixes #16, resolves #5
@JackCuthbert
Copy link
Owner Author

🎉 This issue has been resolved in version 1.4.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JackCuthbert