-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cleanup operation in reference to the Urldate field #9999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on it. Tests look good. Just small code comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The discussed reference is gone. Otherwise, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for me.
Now when thinking of the tests more properly, I think, as user I would have written
\url{http://142.42.1.1:8080/}, accessed on January 15, 2021
(lower case letters for "accessed", ...)
Follow-up to #9970
Fixes #koppor216
Overview on the cleanup operation
Following up to the recently added cleanup operation for the
Url
field, the current proposal serves as a cleanup operation for theUrldate
field of a BibTex entry. Essentially, when a date referring to the access date of a URL address is identified in theNote
field then we move it to theUrldate
field. Including the aforementioned operation, we achieve more precise and effective handling of user's mistaken entries' recording.Step by Step
Note
fieldQuality
sectiona. Selects
Cleanup entries
optionb. Enables
Move URL in note field to url field
actionc. Clicks on
OK
Urldate
field.Some noteworthy comments
Note
field.Note
field, then we only move the first found.Urldate
, no action should be performed, unless the URL-DATES in bothNote
andUrldate
fields are equal. In that case we just remove the url-date from theNote
field.About the implementation
URLCleanup
class with the url-date cleanup operation and made the necessary adjustments (minor refactoring).urldate-cleanup.mov
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)