Enable SimplifyBooleanReturn #9885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koppor
added
the
type: code-quality
|
seems like something with the braces formatter went wrong |
|
Or @koppors manual changes. |
|
These recipes would make results to src/main/java/org/jabref/gui/openoffice/ManageCitationsDialogView.java: |
|
I think the braces can be removed completly |
Siedlerchr
reviewed
May 14, 2023
| } else { | ||
| return true; | ||
| } | ||
| return !(CONJUNCTIONS.contains(word)); |
Siedlerchr
reviewed
May 14, 2023
| return false; | ||
| } | ||
| return true; | ||
| return (viewModel != null) && (!viewModel.failedToGetCitationEntries); |
There was a problem hiding this comment.
at least the brace after the && are uncessary
There was a problem hiding this comment.
Let's see what checkstyle says... I think, it demands some braces?
There was a problem hiding this comment.
I think only in if conditions
Siedlerchr
reviewed
May 14, 2023
src/main/java/org/jabref/gui/openoffice/ManageCitationsDialogView.java
Outdated
Show resolved
Hide resolved
…iew.java Co-authored-by: Christoph <[email protected]>
koppor
added
the
status: ready-for-review
Siedlerchr
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables https://docs.openrewrite.org/recipes/java/cleanup/simplifybooleanreturn
Compulsory checks