Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences ui cleanup #9839

Merged
merged 12 commits into from
May 5, 2023
Merged

Preferences ui cleanup #9839

merged 12 commits into from
May 5, 2023

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented May 4, 2023

  • introduced web search tab
    grafik
  • renamed Import and Export tab to Export tab
    grafik
  • moved remaining content to entry tab, refined ui (reduced vertical space, added indentation)
    grafik
  • removed files tab
  • removed unused code (TagBar / Tag, DiffHighlightingTextPane)

.

Compulsory checks

Preview Give feedback

@calixtus calixtus changed the title Introducing Web search tab Preferences ui cleanup May 4, 2023
@koppor
Copy link
Member

koppor commented May 4, 2023

Reorganization also relates to #9836.

@koppor
Copy link
Member

koppor commented May 4, 2023

We have "Always reformat BIB file on save and export". Should we a) keep this setting both in "Library"/"File"/"General" and in "Export" or should we b) split it into "Always reformat BIB file on save" and "Always reformat BIB file on export". I lean to the former. But then, the UI setting appears in two different tabs. Hopefully, they are synchronized!

@calixtus
Copy link
Member Author

calixtus commented May 4, 2023

I removed the files tab. So the autosave setting should not appear twice.

@Siedlerchr
Copy link
Member

Oh no please not, my other PR is using the files tab

@calixtus
Copy link
Member Author

calixtus commented May 4, 2023

Should not be a big deal to fix the merge conflicts

@calixtus calixtus added type: code-quality Issues related to code or architecture decisions preferences status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels May 4, 2023
@koppor
Copy link
Member

koppor commented May 4, 2023

I removed the files tab. So the autosave setting should not appear twice.

It is about reformatting, not saving. 😅

Saving is only concerning the library, but reformatting both the library (.bib) and export (as .bib).

@calixtus
Copy link
Member Author

calixtus commented May 5, 2023

I will make a follow up PR introducing a library tab. But I think it will be too much for this PR as I already changed 42 files with this one.

@calixtus
Copy link
Member Author

calixtus commented May 5, 2023

Thx for #

@Siedlerchr Siedlerchr merged commit e95fb75 into main May 5, 2023
@Siedlerchr Siedlerchr deleted the websearch_prefs branch May 5, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers type: code-quality Issues related to code or architecture decisions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants