Improved error message when downloading a file fails #9826

[yerraga]

Fixes #9826

Compulsory checks

Preview Give feedback

1. Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
2. Tests created for changes (if applicable)
3. Manually tested changed features in running JabRef (always required)
4. Screenshots added in PR description (for UI changes)
5. Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
6. Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[koppor]

@yerraga Thank you for the contribution. Can you please fix checkstyle? See https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace/intellij-13-code-style.html for details. Please also use {} at the logger (instead of string concatenation)

I think, the whole thing should be tested. Can you dive into WireMock to setup mocking the remote servers - so that each exception path in LinkedFileViewModel is tested? https://wiremock.org/docs/junit-jupiter/

[ThiloteE]

To ease organizational workflows I have linked the pull-request to the issue with syntax as described in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Linking a pull request to an issue using a keyword

You can link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message. The pull request must be on the default branch.

• close
• closes
• closed
• fix
• fixes
• fixed
• resolve
• resolves
• resolved

If you use a keyword to reference a pull request comment in another pull request, the pull requests will be linked. Merging the referencing pull request also closes the referenced pull request.

The syntax for closing keywords depends on whether the issue is in the same repository as the pull request.

[koppor]

The second part is also shown to the user
. Thus, that needs to be localized too. It is OK for me to include the server error here.

[Siedlerchr]

What is the status here? Are you planning to fix the compile errors to get it working?

[calixtus]

Closing this issue due to inactivity 💤
Please reopen a PR if you intend to continue on this issue. We really liked your idea and draft.