Refactored Singlebibtexfield #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
added
cleanup-ops
status: ready-for-review
|
|
||
| // -------------------------------------------------------------------------- | ||
| // a container class for all properties of a bibtex-field | ||
| // -------------------------------------------------------------------------- |
There was a problem hiding this comment.
Have a look at the comments and try to use JavaDoc instead.
|
Very good points! Too much copy-paste (as usual). Will sort it out tomorrow. |
|
Looks good. Other improvements can be made in separate PRs. |
| } | ||
| } | ||
|
|
||
| // ----------------------------------------------------------------------- |
There was a problem hiding this comment.
Can you remove these lines? There are some others in this file similar to this as well.
There was a problem hiding this comment.
Ahh, I missed some...
oscargus
force-pushed
the
singlebibtexfield
branch
from
fc69e3a to
1b52e4c
Compare
simonharrer
added a commit
that referenced
this pull request
Mar 17, 2016
Refactored Singlebibtexfield
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the initial ideas in #978 the class SingleBibtexField is extracted and two EnumSets are used for implementing the existing functionality.