-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved dialog for deletion of multiple files #9711
Conversation
+ changed the call in LinkedFilesEditor to use the new DeleteFileAction class Co-Authored-By: FlorisPex <[email protected]>
Co-Authored-By: FlorisPex <[email protected]>
Thanks for your contribution! Looks good to me. Please add a changelog entry! |
I've already added an entry to |
Ah sorry, now I see the changelog entry. All fine. Seems like I overlooked that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise looks good. One nitpick about the wording: Disk or drive? I'm totally unsure on this. Thinking of terms like "Google Drive" / "OneDrive" etc.
I think "disk" was used already in the existing dialog. Therefore, we adapted our addition using this term. |
Fixes #9473
Created
DeleteFileAction
class that extendsSimpleCommand
. This class handles both the creation of the dialog that either shows a file name or the amount of files, depending on the selection in theLinkedFileViewModel
, as well as the unlinking/deletion itself. Also changed the call inLinkedFilesEditor
when Delete is pressed to use this newDeleteFileAction
class.Compulsory checks
Deletion of a single file:
Deletion of multiple files: