Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved dialog for deletion of multiple files #9711

Merged
merged 3 commits into from
Apr 2, 2023
Merged

Improved dialog for deletion of multiple files #9711

merged 3 commits into from
Apr 2, 2023

Conversation

hiddevanesch
Copy link
Contributor

Fixes #9473

Created DeleteFileAction class that extends SimpleCommand. This class handles both the creation of the dialog that either shows a file name or the amount of files, depending on the selection in the LinkedFileViewModel, as well as the unlinking/deletion itself. Also changed the call in LinkedFilesEditor when Delete is pressed to use this new DeleteFileAction class.

Compulsory checks

Preview Give feedback

Deletion of a single file:
image
Deletion of multiple files:
image

hiddevanesch and others added 2 commits March 28, 2023 16:11
+ changed the call in LinkedFilesEditor to use the new DeleteFileAction class

Co-Authored-By: FlorisPex <[email protected]>
@Siedlerchr Siedlerchr changed the title Fix for issue 9473 Improved dialog for deletion of mulitple files Mar 28, 2023
Siedlerchr
Siedlerchr previously approved these changes Mar 28, 2023
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 28, 2023
@Siedlerchr
Copy link
Member

Thanks for your contribution! Looks good to me. Please add a changelog entry!

@hiddevanesch
Copy link
Contributor Author

hiddevanesch commented Mar 28, 2023

@Siedlerchr

Thanks for your contribution! Looks good to me. Please add a changelog entry!

I've already added an entry to CHANGELOG.md, or do you mean something else?

@hiddevanesch hiddevanesch changed the title Improved dialog for deletion of mulitple files Improved dialog for deletion of multiple files Mar 28, 2023
@Siedlerchr
Copy link
Member

Ah sorry, now I see the changelog entry. All fine. Seems like I overlooked that.

Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise looks good. One nitpick about the wording: Disk or drive? I'm totally unsure on this. Thinking of terms like "Google Drive" / "OneDrive" etc.

@hiddevanesch
Copy link
Contributor Author

hiddevanesch commented Mar 31, 2023

@calixtus

Codewise looks good. One nitpick about the wording: Disk or drive? I'm totally unsure on this. Thinking of terms like "Google Drive" / "OneDrive" etc.

I think "disk" was used already in the existing dialog. Therefore, we adapted our addition using this term.

@Siedlerchr Siedlerchr merged commit 2f4fe44 into JabRef:main Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external files status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting multiple linked files should show a single confirmation dialog
4 participants