-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding text formatting for hits #9686
Conversation
I like the idea, just a question for the last screenshot? Does that mean 100,000 entries? or just 1000? |
looks just like a typo to me, since he had 1000 entries = 1k in his first screenshot... |
Yes it is 100,000. Changed the description now accordingly. |
54e72bb
to
70f7a63
Compare
I tested it, it's a nice idea. However, it does not resolve the original issue: There is still something not right with the padding regarding the font size. You might need to check with https://github.com/JonathanGiles/scenic-view to see what's going on. |
About the size of the controls, labels and stuff: Controls should be sized in relation to the base font size of the main application window. See the documentation on jfx css measure units: docs.oracle.com/javafx/2/api/javafx/scene/doc-files/cssref.html#typelength |
Yeah! Really great work, tested it, works fine! Thanks for digging into this :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
Took the liberty tho shorten the changelog a bit.
@vigneshdurairaj Unfortunately, there was an issue with the update of the item count. However, I was able to adapt your code a bit. FYI: #9709 |
Compulsory checks
Fixes #8797
As first-time contributors, we would like to ensure that our submission adheres to the community guidelines. Consequently, we have submitted this Pull Request as part of our university project. Our team member, @sambhav97, has been assigned to the issue.
We believe that displaying numbers such as 1000 as 1k is a design choice. To provide a visual representation, we have included a screenshot displaying how the entries appear with this change. If there are any oversights or areas for improvement, please do not hesitate to inform us.
When the entries are 1000
When the entries are 1500
When the entries are 100,000