Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of backslashes at the end of field content #9677

Merged
merged 6 commits into from
Mar 18, 2023
Merged

Conversation

koppor
Copy link
Member

@koppor koppor commented Mar 16, 2023

This refs #9668, but does not fully fix it, but eliminates the main issue.

Additional changes:

  • New round trip tests at BibEntryWriterTest - they currently work
  • Within a class, spell BibTeX consistently.
  • ImportHandler should use the provided FileUpdateMonitor
  • While working on fixing jabref automatically deletes entries showing wrong syntax #9668, I encountered that the BibTeX entry cannot be pasted using the clipboard. Alsof ixed
    image

Tested in the GUI:

image

image

This somehow refs JabRef#52.


  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor
Copy link
Member Author

koppor commented Mar 17, 2023

This addresses the concrete user description at #9668.

However, there is much work to do address the concrete user request. -- In case an entry cannot be parsed, it is still dropped. See also #9668 (comment)

@koppor koppor changed the title Fix importing of backslashes Fix parsing of backslashes at the end of field content Mar 17, 2023
@koppor koppor marked this pull request as ready for review March 17, 2023 12:38
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 17, 2023
Siedlerchr
Siedlerchr previously approved these changes Mar 18, 2023
@koppor koppor added this to the v5.10 milestone Mar 18, 2023
Siedlerchr
Siedlerchr previously approved these changes Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
import status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants