open office csv format correction for abstract column #9570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Please take a look at the checkstyle/reviewdog issues. Please also add a unit test for the formatter |
Siedlerchr
added
the
status: ready-for-review
|
looks good to me, please also add a changelog entry and please also add a short line to the docs about the new formatter |
calixtus
approved these changes
Jan 22, 2023
|
Thank you for your contribution. We would be happy to see more contributions from your side. We use the label good-first-issue, where more issues will be tagged. You can also have a look at https://github.com/koppor/jabref/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22. |
Siedlerchr
added a commit
that referenced
this pull request
Jan 28, 2023
…ialog * upstream/main: Fixed ADS tests Bump junit-jupiter from 5.9.1 to 5.9.2 (#9579) Bump actions/configure-pages from 2 to 3 open office csv format correction for abstract column (#9570) Update CHANGELOG.md add change log entry for the given change typo removed (#9577) remove filter that consumes mouse rightclick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9087
Problem-It was skipping commas dues to presence of double quotes inside a single column.
Solution- A single double quote(") is replace by 2 double quotes ("") .
https://stackoverflow.com/questions/769621/dealing-with-commas-in-a-csv-file
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)Manually tested for inputs mentioned in issues