Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort unique library suffix by length #9568

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Sort unique library suffix by length #9568

merged 3 commits into from
Jan 18, 2023

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Jan 17, 2023

Fixes #9567

Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/70

grafik

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 17, 2023
@ThiloteE
Copy link
Member

tested. works for me.

@ThiloteE ThiloteE merged commit 5879c27 into main Jan 18, 2023
@ThiloteE ThiloteE deleted the fixLibraryImportInto branch January 18, 2023 19:33
Siedlerchr added a commit that referenced this pull request Jan 18, 2023
* upstream/main: (23 commits)
  Sort unique library suffix by length (#9568)
  Avoid using Globals.entryTypeManager
  try with liberica jdk
  test with unsigned image
  adjust dmg scpt and add mac sign id
  don't use keychain profile
  use older one
  return true in case security keychain not existing
  readd old codesiginng steps
  codesign image with timestamp
  read app image
  fuu yaml
  again
  try contains
  try to add braces
  fix error in yaml
  test new codesigning
  Test entries equality based on their citation key
  Fix failing tests
  Detect more cases when an entry is modified
  ...

# Conflicts:
#	CHANGELOG.md
Siedlerchr added a commit that referenced this pull request Jan 21, 2023
…ialog

* upstream/main:
  Fix date parsing for Doab fetcher
  Sort unique library suffix by length (#9568)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library to import into does not show correct library names when two have the same suffix
3 participants