Set default value for fulltext indexing to false #9516
Conversation
|
This PR refs #9491 |
| @@ -692,7 +692,7 @@ private JabRefPreferences() { | |||
| // Download files by default | |||
| defaults.put(DOWNLOAD_LINKED_FILES, true); | |||
| // Create Fulltext-Index by default | |||
| defaults.put(FULLTEXT_INDEX_LINKED_FILES, true); | |||
| defaults.put(FULLTEXT_INDEX_LINKED_FILES, false); | |||
There was a problem hiding this comment.
Actually I would leave this as true and only the search button deactivated for the moment
There was a problem hiding this comment.
It's what we literally discussed yesterday and decided againstindexing fulltext by default.
There was a problem hiding this comment.
I personally changed my mind after the meeting.
If indexing is disabled, users will try to use file search, but it will not work. Users will not know that they first have to enable indexing for file search to work. They will report that file search is broken. Disable indexing only, once users are somehow notified that file search can only be used, if indexing is enabled.
There was a problem hiding this comment.
yes we discussed also that this is not to be implemented as the lucene search pr of @btut changes so many things with the search that there should not be made any major changes in behaviour, GUI or logic, since all this work would be thrown away when or have to be undone before merging the lucene PR.
Decisions were made for a reason yesterday. Don't start rediscussing what we already decided yesterday.
There was a problem hiding this comment.
Yesterdays discussion notes: #9491 (comment)
calixtus
added
status: ready-for-review
| @@ -224,7 +223,7 @@ private void initSearchModifierButtons() { | |||
| fulltextButton.setSelected(searchPreferences.isFulltext()); | |||
| fulltextButton.setTooltip(new Tooltip(Localization.lang("Fulltext search"))); | |||
| initSearchModifierButton(fulltextButton); | |||
| EasyBind.subscribe(preferencesService.getFilePreferences().fulltextIndexLinkedFilesProperty(), value -> fulltextButton.setDisable(!value)); | |||
| fulltextButton.disableProperty().bind(preferencesService.getFilePreferences().fulltextIndexLinkedFilesProperty().not()); | |||
There was a problem hiding this comment.
Still Needs to be bound to the UI button state and maybe we can bind managed (completely removed from the UI) to the fulltextIndexLinkedFilesProperty property
Siedlerchr
removed
the
status: ready-for-review
| fulltextButton.setTooltip(new Tooltip(Localization.lang("Fulltext search"))); | ||
| initSearchModifierButton(fulltextButton); | ||
| EasyBind.subscribe(preferencesService.getFilePreferences().fulltextIndexLinkedFilesProperty(), value -> fulltextButton.setDisable(!value)); |
There was a problem hiding this comment.
This is a nice idea! Additionally, it should set the button state to "false" if the fulltext search is deactivated (and only then)
fixes #9491
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)