Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the size of entries number in groups tab #9449

Closed
wants to merge 3 commits into from

Conversation

alescrocaro
Copy link

@alescrocaro alescrocaro commented Dec 12, 2022

Changed the size of entries number in groups tab.
Fixes #8797

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

See screenshots of manual tests below

1 entry file (entry with 1 digit)

Image

12 entries file (entries with 2 digits)

Image

103 entries file (entries with 3 digits)

Image

1004 entries file (entries with 4 digits)

Image

10005 entries file (entries with 5 digits)

Image

100006 entries file (entries with 6 digits)

Image

1000007 entries file (entries with 7 digits)

We couldn't reproduce the error for this amount of entries, because of a heap error that we believe is not related to the issue.
Image

@Siedlerchr
Copy link
Member

I can still reproduce it. Go to Preferences -> Appearance ->
grafik

You need to take the font size into account e.g. calculate the size based on the font. Ideally you would use "em" as unit in the width and height settings so that the size is relative to the scaling

Alternatively
Some example that might help https://rextester.com/NZG51913

grafik

#8797 (comment)

@Siedlerchr Siedlerchr added the status: changes required Pull requests that are not yet complete label Dec 12, 2022
@Siedlerchr
Copy link
Member

What's the status here? Are you going to continue working on this?

@Siedlerchr
Copy link
Member

Closing this PR due to inactivity 💤 and as the issue is not solved.

@Siedlerchr Siedlerchr closed this Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: changes required Pull requests that are not yet complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Groups only show 4 digit number of entries
2 participants