Removed swing from default file dir detection #9222

tobiasdiez · 2022-10-07T18:05:45Z

We revert parts of #9113 and remove the default main file dir again since this loads the full awt toolkit which has a large memory and cpu overhead:

        at java.desktop/sun.awt.X11GraphicsEnvironment.initDisplay(Native Method)
        at java.desktop/sun.awt.X11GraphicsEnvironment$1.run(X11GraphicsEnvironment.java:105)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:692)
        at java.desktop/sun.awt.X11GraphicsEnvironment.initStatic(X11GraphicsEnvironment.java:64)
        at java.desktop/sun.awt.X11GraphicsEnvironment.<clinit>(X11GraphicsEnvironment.java:59)
        at java.desktop/sun.awt.PlatformGraphicsInfo.createGE(PlatformGraphicsInfo.java:36)
        at java.desktop/java.awt.GraphicsEnvironment$LocalGE.createGE(GraphicsEnvironment.java:93)
        at java.desktop/java.awt.GraphicsEnvironment$LocalGE.<clinit>(GraphicsEnvironment.java:84)
        at java.desktop/java.awt.GraphicsEnvironment.getLocalGraphicsEnvironment(GraphicsEnvironment.java:106)
        at java.desktop/sun.awt.X11.XToolkit.<clinit>(XToolkit.java:224)
        at java.desktop/sun.awt.PlatformGraphicsInfo.createToolkit(PlatformGraphicsInfo.java:40)
        at java.desktop/java.awt.Toolkit.getDefaultToolkit(Toolkit.java:599)
        at java.desktop/sun.swing.SwingUtilities2.getSystemMnemonicKeyMask(SwingUtilities2.java:2198)
        at java.desktop/javax.swing.plaf.basic.BasicLookAndFeel.initComponentDefaults(BasicLookAndFeel.java:1100)
        at java.desktop/javax.swing.plaf.metal.MetalLookAndFeel.initComponentDefaults(MetalLookAndFeel.java:445)
        at java.desktop/javax.swing.plaf.basic.BasicLookAndFeel.getDefaults(BasicLookAndFeel.java:153)
        at java.desktop/javax.swing.plaf.metal.MetalLookAndFeel.getDefaults(MetalLookAndFeel.java:1565)
        at java.desktop/javax.swing.UIManager.setLookAndFeel(UIManager.java:593)
        at java.desktop/javax.swing.UIManager.setLookAndFeel(UIManager.java:635)
        at java.desktop/javax.swing.UIManager.initializeDefaultLAF(UIManager.java:1412)
        at java.desktop/javax.swing.UIManager.initialize(UIManager.java:1525)
        at java.desktop/javax.swing.UIManager.maybeInitialize(UIManager.java:1491)
        at java.desktop/javax.swing.UIManager.getDefaults(UIManager.java:716)
        at java.desktop/javax.swing.UIManager.getString(UIManager.java:845)
        at java.desktop/javax.swing.filechooser.UnixFileSystemView.<clinit>(FileSystemView.java:777)
        at java.desktop/javax.swing.filechooser.FileSystemView.getFileSystemView(FileSystemView.java:93)
        at [email protected]/org.jabref.gui.desktop.JabRefDesktop.getDefaultFileChooserDirectory(JabRefDesktop.java:307)
        at [email protected]/org.jabref.preferences.JabRefPreferences.determineMainFileDirectory(JabRefPreferences.java:2193)
        at [email protected]/org.jabref.preferences.JabRefPreferences.getFilePreferences(JabRefPreferences.java:2204)
        at [email protected]/org.jabref.preferences.JabRefPreferences.getFileLinkPreferences(JabRefPreferences.java:1112)
        at [email protected]/org.jabref.preferences.JabRefPreferences.getLayoutFormatterPreferences(JabRefPreferences.java:1125)
        at [email protected]/org.jabref.preferences.JabRefPreferences.getCustomExportFormats(JabRefPreferences.java:2308)
        at [email protected]/org.jabref.cli.Launcher.applyPreferences(Launcher.java:158)
        at [email protected]/org.jabref.cli.Launcher.main(Launcher.java:65)

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Siedlerchr · 2022-10-07T18:45:06Z

AS per @koppor said, the average user does look in his documents for files and not where the bib file is located (that might be the downloads files).
And user.home is not reliable. That's why we decided to use the awt method. Unfortunately there is no other non awt swing version available

koppor · 2022-10-07T18:48:45Z

Is there a test for:

File directory defined in .bib file
File directory not accessible from the user
JabRef stores the PDF NOT next to the .bib file, but in the home-directory, sub directory "JabRef" ("My Documents" -> "JabRef")

This is important for shared .bib files where users use Mac OS X and the path is configured for Windows.

Moreover, storing relative to the bib file is default, so I don't get why there is a change needed in the logic here

calixtus · 2022-10-07T23:13:36Z

src/main/java/org/jabref/logic/layout/format/FileLinkPreferences.java

    private final List<Path> fileDirForDatabase;

-    public FileLinkPreferences(String mainFileDirectory, List<Path> fileDirForDatabase) {
+    public FileLinkPreferences(Optional<Path> mainFileDirectory, List<Path> fileDirForDatabase) {


I really don't like the optional as a method argument here. Does not seem to provide any advantage of just returning Optional.offNullable in getMainFileDirecty but bad readability, and construction of a superfluous optional object...

This is mostly to support new FileLinkPreferences(getFilePreferences().getFileDirectory(),...); where getFileDirectory returns an optional.

Just thinking loud:

Should mainFileDirectory ever be empty? Do we have a default value for this -> .orElse()? Reason: Have guaranteed non-null objects to avoid later checking for nulls or empty.

Maybe overload the constructor to avoid "Optional.empty()"

Olly's idea was to add a default for mainFileDirectory. But in case we don't find a nice solution for getting the user doc folder, the idea of this PR is to make it clear that the main file directory might not be present.

next quick thought without deeper thinking 😅 : why is the mainFileDirectory not just the first Value of fileDirForDatabase?

Olly's idea was to add a default for mainFileDirectory.

Yes!

But in case we don't find a nice solution for getting the user doc folder,

AWT is the currently best solution - AWT is still bundled with Java.

calixtus · 2022-10-07T23:23:25Z

I can totally relate on one hand to @tobiasdiez idea of getting rid of swing to reduce overhead and I remember we had this conversation before. On the other hand we still use swing for all the undo/redo stuff, so sadly there is no short term advantage here and as i understand the default behaviour if jabref is already in favor of tobias intuition.
I believe there is currently no better solution but to relate on swing to determine the 'My Documents' directory. Maybe we can discuss this in the next dev call and write a quick and simple ADR on this to find a joint consensus decision on that?

tobiasdiez · 2022-10-08T08:55:13Z

As far as I remember, the Undo/Redo stuff doesn't start and require the awt toolkit. It's essentially a data holder. This is similar to the JavaFX collections that also can be used without the JavaFX toolkit.

I don't think this special case is so important that we pull in the awt toolkit, nor go down the JNI rabbit hole. But I'm happy to use another easy workaround...

koppor · 2022-10-10T18:56:46Z

Current behavior:

See org.jabref.model.database.BibDatabaseContext#getFileDirectories

        // 1. Metadata user-specific directory
        metaData.getUserFileDirectory(preferences.getUser())
                .ifPresent(userFileDirectory -> fileDirs.add(getFileDirectoryPath(userFileDirectory)));

        // 2. Metadata general directory
        metaData.getDefaultFileDirectory()
                .ifPresent(metaDataDirectory -> fileDirs.add(getFileDirectoryPath(metaDataDirectory)));

        // 3. BIB file directory or Main file directory
        // fileDirs.isEmpty in the case, 1) no user-specific file directory and 2) no general file directory is set
        // (in the metadata of the bib file)
        if (fileDirs.isEmpty() && preferences.shouldStoreFilesRelativeToBibFile()) {
...
        } else {
            // Main file directory
            preferences.getFileDirectory().ifPresent(fileDirs::add);
        }

Thus, the behavior @tobiasdiez encounters happens in the follwing

org.jabref.gui.externalfiles.DownloadFullTextAction#downloadFullTexts is called
This calls org.jabref.model.database.BibDatabaseContext#getFirstExistingFileDir
This gathers all available directories (org.jabref.model.database.BibDatabaseContext#getFileDirectories)
Filters available directories based on Files.exists

Special case in step 3:

In case no meta data directory is set AND files should NOT be stored related to bib file, then the main file directory is used.

That means, the encountered behavior can only occur, if a meta directory is set AND none of these directories exist (because of step 4).

This was the intended "hack" of #9113.

@tobias, please explain how the following issue arises at your side:

save files again relative to the bib folder if no other folder has been selected (i.e no file directory on the bib file level nor on the user level).

The current implementation seems to follow this behavior (see above).

koppor · 2022-10-10T18:57:51Z

We created ADR-0026 at #9235. We close this PR until we find the root cause of the issue at @tobiasdiez's machine.

In parallel, we are thinking of contributing to AppDirs.

tobiasdiez · 2022-10-10T21:14:23Z

Just try to start the JabRef cli from #9217 in a terminal (without any window server running) and you get:

Exception in thread "main" java.awt.AWTError: Can't connect to X11 window server using ':1' as the value of the DISPLAY variable.
        at java.desktop/sun.awt.X11GraphicsEnvironment.initDisplay(Native Method)
        at java.desktop/sun.awt.X11GraphicsEnvironment$1.run(X11GraphicsEnvironment.java:105)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:692)
        at java.desktop/sun.awt.X11GraphicsEnvironment.initStatic(X11GraphicsEnvironment.java:64)
        at java.desktop/sun.awt.X11GraphicsEnvironment.<clinit>(X11GraphicsEnvironment.java:59)
        at java.desktop/sun.awt.PlatformGraphicsInfo.createGE(PlatformGraphicsInfo.java:36)
        at java.desktop/java.awt.GraphicsEnvironment$LocalGE.createGE(GraphicsEnvironment.java:93)
        at java.desktop/java.awt.GraphicsEnvironment$LocalGE.<clinit>(GraphicsEnvironment.java:84)
        at java.desktop/java.awt.GraphicsEnvironment.getLocalGraphicsEnvironment(GraphicsEnvironment.java:106)
        at java.desktop/sun.awt.X11.XToolkit.<clinit>(XToolkit.java:224)
        at java.desktop/sun.awt.PlatformGraphicsInfo.createToolkit(PlatformGraphicsInfo.java:40)
        at java.desktop/java.awt.Toolkit.getDefaultToolkit(Toolkit.java:599)
        at java.desktop/sun.swing.SwingUtilities2.getSystemMnemonicKeyMask(SwingUtilities2.java:2198)
        at java.desktop/javax.swing.plaf.basic.BasicLookAndFeel.initComponentDefaults(BasicLookAndFeel.java:1100)
        at java.desktop/javax.swing.plaf.metal.MetalLookAndFeel.initComponentDefaults(MetalLookAndFeel.java:445)
        at java.desktop/javax.swing.plaf.basic.BasicLookAndFeel.getDefaults(BasicLookAndFeel.java:153)
        at java.desktop/javax.swing.plaf.metal.MetalLookAndFeel.getDefaults(MetalLookAndFeel.java:1565)
        at java.desktop/javax.swing.UIManager.setLookAndFeel(UIManager.java:593)
        at java.desktop/javax.swing.UIManager.setLookAndFeel(UIManager.java:635)
        at java.desktop/javax.swing.UIManager.initializeDefaultLAF(UIManager.java:1412)
        at java.desktop/javax.swing.UIManager.initialize(UIManager.java:1525)
        at java.desktop/javax.swing.UIManager.maybeInitialize(UIManager.java:1491)
        at java.desktop/javax.swing.UIManager.getDefaults(UIManager.java:716)
        at java.desktop/javax.swing.UIManager.getString(UIManager.java:845)
        at java.desktop/javax.swing.filechooser.UnixFileSystemView.<clinit>(FileSystemView.java:777)
        at java.desktop/javax.swing.filechooser.FileSystemView.getFileSystemView(FileSystemView.java:93)
        at [email protected]/org.jabref.gui.desktop.JabRefDesktop.getDefaultFileChooserDirectory(JabRefDesktop.java:307)
        at [email protected]/org.jabref.preferences.JabRefPreferences.determineMainFileDirectory(JabRefPreferences.java:2193)
        at [email protected]/org.jabref.preferences.JabRefPreferences.getFilePreferences(JabRefPreferences.java:2204)
        at [email protected]/org.jabref.preferences.JabRefPreferences.getFileLinkPreferences(JabRefPreferences.java:1112)
        at [email protected]/org.jabref.preferences.JabRefPreferences.getLayoutFormatterPreferences(JabRefPreferences.java:1125)
        at [email protected]/org.jabref.preferences.JabRefPreferences.getCustomExportFormats(JabRefPreferences.java:2308)
        at [email protected]/org.jabref.cli.Launcher.applyPreferences(Launcher.java:158)
        at [email protected]/org.jabref.cli.Launcher.main(Launcher.java:65)

While we might want to argue that this use case (running JabRef without a window server) is not the most relevant, the error log shows however that the full awt toolkit is initialized by the call to the default file chooser: java.awt.Toolkit.getDefaultToolkit(Toolkit.java:599). In my opinion, this memory and cpu overhead is unacceptable just to provide a slightly better default preference value.

calixtus · 2022-10-12T09:08:12Z

I experimented a bit. How about this bad boy:

import com.sun.jna.platform.win32.KnownFolders;
import com.sun.jna.platform.win32.Shell32Util;

Shell32Util.getKnownFolderPath(KnownFolders.FOLDERID_Documents);

It seems there is no additional dependency needed, at least my ide is not complaining.
Needs to be made os dependent differently for mac and unix though and can should maybe have a failsafe for older win versions, see https://github.com/harawata/appdirs/blob/2ade924b09b06d2f0b80e10f00ea01c191d5ff6a/src/main/java/net/harawata/appdirs/impl/ShellFolderResolver.java#L28-L44

Siedlerchr · 2022-10-12T09:10:20Z

@calixtus I am not sure about the access to the internal of com sun modules. Maybe needs some flags in for modules

calixtus · 2022-10-12T09:12:23Z

JNA is not an internal api, but publicly well documented and widely used.
https://java-native-access.github.io/jna/5.12.1/javadoc/
https://github.com/java-native-access/jna

calixtus · 2022-10-12T09:22:50Z

calixtus · 2022-10-12T09:25:01Z

This would have to be added to the module-info.java: requires com.sun.jna.platform;

Siedlerchr · 2022-10-12T09:51:12Z

Try if this doesn't break jpackage

tobiasdiez · 2022-10-12T10:20:17Z

Nice suggestion @calixtus. I think its best to submit this addition as a PR to AppDirs, which already takes care of the special handling of the different OS's.

Since this is a blocker for a 5.8 release in my opinion, should we first merge this PR here and once AppDirs provides the necessary functionality we can re-introduce the default file dir?

calixtus · 2022-10-12T10:50:50Z

I will suggest it to AppDirs, but I think it may be a bit out of focus for them, since the name if the package and it's whole architecture seems to me clearly designed to hide every other KnownFolder from public access in this package. I'd rather opt for implementing a similar approach in our OS or sthg like package.

src/main/java/org/jabref/preferences/FilePreferences.java

* upstream/main: Make autosave tick in shared database opening dialog active (#9258) Bump controlsfx from 11.1.1 to 11.1.2 (#9261) Bump actions/configure-pages from 1 to 2 (#9262) Bump hmarr/auto-approve-action from 2.4.0 to 3.0.0 (#9259) Bump gittools/actions from 0.9.13 to 0.9.14 (#9260) Fix for resizing cleanup entries dialog (#9240) Refresh example styles Squashed 'buildres/csl/csl-locales/' changes from cb98d36691..e243665390 Squashed 'buildres/csl/csl-styles/' changes from 7bde3e4..4eee79a Fix casing Update contributing.md Remove obsolete Jekyll howto Updates Just-the-Docs from 0.3.3 to 0.4.0.rc3 (#9249) Place subgroups w.r.t. alphabetical ordering (#9228) DOAB Fetcher now fetches ISBN and imprint fields where possible (#9229) ISSUE-9145: implement isbn fetcher (#9205) Remove explicit javafx jmod stuff (#9245) New Crowdin updates (#9239)

This reverts commit 3e640f5. # Conflicts: # CHANGELOG.md # src/main/java/org/jabref/preferences/FilePreferences.java # src/main/java/org/jabref/preferences/JabRefPreferences.java # src/test/java/org/jabref/model/database/BibDatabaseContextTest.java

…_file_dir * upstream/default_file_dir: Update src/main/java/org/jabref/gui/desktop/os/Windows.java

Siedlerchr · 2022-10-17T18:33:09Z

This PR is now ready. I refactored the Optional stuff again, and Carl implemented the JNI access.
Thanks for pointing out the overhead with initializing the awt/swing stuff @tobiasdiez

calixtus · 2022-10-17T18:34:10Z

This is odd, because swing is now back in the package

src/main/java/org/jabref/gui/desktop/JabRefDesktop.java

src/main/java/org/jabref/gui/desktop/os/NativeDesktop.java

tobiasdiez · 2022-10-17T18:46:51Z

src/main/java/org/jabref/preferences/JabRefPreferences.java

@@ -2201,7 +2188,9 @@ public FilePreferences getFilePreferences() {

        filePreferences = new FilePreferences(
                getInternalPreferences().getUser(),
-                determineMainFileDirectory(get(MAIN_FILE_DIRECTORY)),
+                StringUtil.isNotBlank(get(MAIN_FILE_DIRECTORY))


Refactor to

Suggested change

StringUtil.isNotBlank(get(MAIN_FILE_DIRECTORY))

getPath(MAIN_FILE_DIRECTORY).orElse(JabRefDesktop.getNativeDesktop().getDefaultFileChooserDirectory())

There's so such nethod. And I don't see the benefit of wrapping it an optional here.

StringUtil.isNotBlank(...) is - I believe - the equivalent to `... != null && !....isEmpty()", so should simplify determineMainFileDirectory

On the other hand, method get is called twice. Maybe we can extract the var from the constructor call

Since we store quite a few paths in the preferences, it makes sense to introduce a helper for it in my opinion. You can also introduce a second default arg:

getPath(string name, Path defaultVal) { val = get(name) return StringUtil.isNotBlank(val) ? Path.of(val) : defaultVal }

I've reintroduced a method

fix checkstyle

calixtus · 2022-10-17T19:44:32Z

tests are failing since a51570d (#9222) , but they were working with eab433c (#9222)

src/main/java/org/jabref/gui/desktop/os/Linux.java

fix env var

* upstream/main: Removed swing from default file dir detection (#9222) # Conflicts: # src/main/java/org/jabref/gui/desktop/os/Linux.java

* upstream/main: Removed swing from default file dir detection (#9222) Make autosave tick in shared database opening dialog active (#9258) Bump controlsfx from 11.1.1 to 11.1.2 (#9261) Bump actions/configure-pages from 1 to 2 (#9262) Bump hmarr/auto-approve-action from 2.4.0 to 3.0.0 (#9259) Bump gittools/actions from 0.9.13 to 0.9.14 (#9260)

* Save files again relative to bib file * Reworded * Reintroduced default file chooser directory without swing * Update CHANGELOG.md * Update CHANGELOG.md * Update NativeDesktop.java * Reworked ADR * Added mac directory * Removed comments * Added linux support * Revert "Save files again relative to bib file" This reverts commit 3e640f5. # Conflicts: # CHANGELOG.md # src/main/java/org/jabref/preferences/FilePreferences.java # src/main/java/org/jabref/preferences/JabRefPreferences.java # src/test/java/org/jabref/model/database/BibDatabaseContextTest.java * Update src/main/java/org/jabref/gui/desktop/os/Windows.java * fix merge errors * fix wrong method call * remove defautl fix checkstyle * reintroduce method to avoid calling get two times * Introduced getPath method * Update src/main/java/org/jabref/gui/desktop/os/Linux.java fix env var Co-authored-by: Carl Christian Snethlage <[email protected]> Co-authored-by: Siedlerchr <[email protected]>

* upstream/main: (28 commits) Minor code improvements in library properties dialog (#9265) Adjust and make tests for BibTex/Biblatex/CSL mapping more accurate by adding Apa 7th edition (#9255) Removed swing from default file dir detection (#9222) Make autosave tick in shared database opening dialog active (#9258) Bump controlsfx from 11.1.1 to 11.1.2 (#9261) Bump actions/configure-pages from 1 to 2 (#9262) Bump hmarr/auto-approve-action from 2.4.0 to 3.0.0 (#9259) Bump gittools/actions from 0.9.13 to 0.9.14 (#9260) Fix for resizing cleanup entries dialog (#9240) Refresh example styles Squashed 'buildres/csl/csl-locales/' changes from cb98d36691..e243665390 Squashed 'buildres/csl/csl-styles/' changes from 7bde3e4..4eee79a Fix casing Update contributing.md Remove obsolete Jekyll howto Updates Just-the-Docs from 0.3.3 to 0.4.0.rc3 (#9249) Place subgroups w.r.t. alphabetical ordering (#9228) DOAB Fetcher now fetches ISBN and imprint fields where possible (#9229) ISSUE-9145: implement isbn fetcher (#9205) Remove explicit javafx jmod stuff (#9245) ...

* upstream/main: [WIP] Add GitHub action: Greetings.yml - Automates advice to JabRefs first time code contributors (JabRef#9272) Minor code improvements in library properties dialog (JabRef#9265) Adjust and make tests for BibTex/Biblatex/CSL mapping more accurate by adding Apa 7th edition (JabRef#9255) Removed swing from default file dir detection (JabRef#9222) Make autosave tick in shared database opening dialog active (JabRef#9258) Bump controlsfx from 11.1.1 to 11.1.2 (JabRef#9261) Bump actions/configure-pages from 1 to 2 (JabRef#9262) Bump hmarr/auto-approve-action from 2.4.0 to 3.0.0 (JabRef#9259) Bump gittools/actions from 0.9.13 to 0.9.14 (JabRef#9260) Fix for resizing cleanup entries dialog (JabRef#9240) Refresh example styles Squashed 'buildres/csl/csl-locales/' changes from cb98d36691..e243665390 Squashed 'buildres/csl/csl-styles/' changes from 7bde3e4..4eee79a Fix casing Update contributing.md Remove obsolete Jekyll howto Updates Just-the-Docs from 0.3.3 to 0.4.0.rc3 (JabRef#9249) Place subgroups w.r.t. alphabetical ordering (JabRef#9228) DOAB Fetcher now fetches ISBN and imprint fields where possible (JabRef#9229)

Save files again relative to bib file

3e640f5

tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 7, 2022

tobiasdiez mentioned this pull request Oct 7, 2022

Process CLI arguments before starting gui #9217

Merged

6 tasks

Siedlerchr removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 7, 2022

calixtus reviewed Oct 7, 2022

View reviewed changes

calixtus added the status: devcall label Oct 7, 2022

koppor closed this Oct 10, 2022

koppor removed the status: devcall label Oct 10, 2022

tobiasdiez reopened this Oct 10, 2022

Merge branch 'main' into default_file_dir

7ab692b

tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 10, 2022

tobiasdiez changed the title ~~Save files again relative to bib file~~ Remove setting a default main file dir Oct 10, 2022

calixtus added 3 commits October 12, 2022 17:05

Merge remote-tracking branch 'upstream/main' into default_file_dir

e50a684

Reworded

de27af5

Reintroduced default file chooser directory without swing

0749128

Siedlerchr reviewed Oct 13, 2022

View reviewed changes

src/main/java/org/jabref/preferences/FilePreferences.java Outdated Show resolved Hide resolved

Siedlerchr added 5 commits October 17, 2022 19:59

Update src/main/java/org/jabref/gui/desktop/os/Windows.java

6b28d08

fix merge errors

1082344

Merge remote-tracking branch 'upstream/default_file_dir' into default…

fc4eccc

…_file_dir * upstream/default_file_dir: Update src/main/java/org/jabref/gui/desktop/os/Windows.java

fix wrong method call

a51570d

tobiasdiez commented Oct 17, 2022

View reviewed changes

src/main/java/org/jabref/gui/desktop/JabRefDesktop.java Outdated Show resolved Hide resolved

src/main/java/org/jabref/gui/desktop/os/NativeDesktop.java Outdated Show resolved Hide resolved

tobiasdiez commented Oct 17, 2022

View reviewed changes

Siedlerchr and others added 3 commits October 17, 2022 20:48

remove defautl

5dd4bd8

fix checkstyle

reintroduce method to avoid calling get two times

aa7e7a9

Introduced getPath method

44aa9dc

Siedlerchr reviewed Oct 17, 2022

View reviewed changes

src/main/java/org/jabref/gui/desktop/os/Linux.java Outdated Show resolved Hide resolved

Update src/main/java/org/jabref/gui/desktop/os/Linux.java

486b8b2

fix env var

Siedlerchr added the hacktoberfest-accepted label Oct 17, 2022

Siedlerchr merged commit 25a8cd3 into main Oct 17, 2022

Siedlerchr deleted the default_file_dir branch October 17, 2022 20:39

Siedlerchr added a commit that referenced this pull request Oct 18, 2022

Merge remote-tracking branch 'upstream/main' into testmain

08dc5d7

* upstream/main: Removed swing from default file dir detection (#9222) # Conflicts: # src/main/java/org/jabref/gui/desktop/os/Linux.java

koppor mentioned this pull request Nov 6, 2022

Adds missing "requires" statement #9354

Merged

6 tasks

ThiloteE mentioned this pull request Jan 13, 2023

Main file directory is used if not empty, even if deactivated #9556

Open

2 tasks

This was referenced May 2, 2023

Respect OS language at NativeDesktop#getDefaultFileChooserDirectory #9835

Closed

Respect localization for main directory (e.g., ~/Dokkumente) #8010

Closed

Respect OS language at NativeDesktop#getDefaultFileChooserDirectory #9837

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removed swing from default file dir detection #9222

Removed swing from default file dir detection #9222

tobiasdiez commented Oct 7, 2022 •

edited by calixtus

Loading

Siedlerchr commented Oct 7, 2022

koppor commented Oct 7, 2022

calixtus Oct 7, 2022

tobiasdiez Oct 8, 2022

calixtus Oct 8, 2022

tobiasdiez Oct 8, 2022

calixtus Oct 8, 2022

koppor Oct 10, 2022

calixtus commented Oct 7, 2022

tobiasdiez commented Oct 8, 2022

koppor commented Oct 10, 2022

koppor commented Oct 10, 2022

tobiasdiez commented Oct 10, 2022

calixtus commented Oct 12, 2022

Siedlerchr commented Oct 12, 2022

calixtus commented Oct 12, 2022

calixtus commented Oct 12, 2022

calixtus commented Oct 12, 2022

Siedlerchr commented Oct 12, 2022

tobiasdiez commented Oct 12, 2022

calixtus commented Oct 12, 2022

Siedlerchr commented Oct 17, 2022

calixtus commented Oct 17, 2022

tobiasdiez Oct 17, 2022

Siedlerchr Oct 17, 2022

calixtus Oct 17, 2022

calixtus Oct 17, 2022

tobiasdiez Oct 17, 2022

Siedlerchr Oct 17, 2022

calixtus commented Oct 17, 2022

	StringUtil.isNotBlank(get(MAIN_FILE_DIRECTORY))
	getPath(MAIN_FILE_DIRECTORY).orElse(JabRefDesktop.getNativeDesktop().getDefaultFileChooserDirectory())

Removed swing from default file dir detection #9222

Removed swing from default file dir detection #9222

Conversation

tobiasdiez commented Oct 7, 2022 • edited by calixtus Loading

Siedlerchr commented Oct 7, 2022

koppor commented Oct 7, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

calixtus commented Oct 7, 2022

tobiasdiez commented Oct 8, 2022

koppor commented Oct 10, 2022

koppor commented Oct 10, 2022

tobiasdiez commented Oct 10, 2022

calixtus commented Oct 12, 2022

Siedlerchr commented Oct 12, 2022

calixtus commented Oct 12, 2022

calixtus commented Oct 12, 2022

calixtus commented Oct 12, 2022

Siedlerchr commented Oct 12, 2022

tobiasdiez commented Oct 12, 2022

calixtus commented Oct 12, 2022

Siedlerchr commented Oct 17, 2022

calixtus commented Oct 17, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

calixtus commented Oct 17, 2022

tobiasdiez commented Oct 7, 2022 •

edited by calixtus

Loading