Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve startup-behavior of pdf indexer #9166

Merged
merged 6 commits into from
Sep 21, 2022
Merged

Improve startup-behavior of pdf indexer #9166

merged 6 commits into from
Sep 21, 2022

Conversation

btut
Copy link
Contributor

@btut btut commented Sep 20, 2022 •
edited
Loading

PdfIndexing is improved in two ways:

  • fix a bug that caused re-indexing on each start of JabRef
  • add an empty entry to the index for files JabRef was not able to read (happens a lot due to missing fonts). This way JabRef knows the file was already read and will not try again on the next start (assuming the read would fail again).

Fixes #8420

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@btut btut requested a review from Siedlerchr September 20, 2022 18:07
@btut btut changed the title Improve pdf indexing Improve startup-behavior of pdf indexer Sep 20, 2022
@btut btut added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers component: search labels Sep 20, 2022
@Siedlerchr
Copy link
Member

lgtm overall, just minor thing

Siedlerchr
Siedlerchr approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just nitpicking

@btut @Siedlerchr
Apply suggestions from code review
25dd1c7 
String replacements

Co-authored-by: Christoph <[email protected]>
@btut
Copy link
Contributor Author

btut commented Sep 21, 2022

Thanks for the suggestions, let's wait for the unit tests and I think then we can merge the fix.

@Siedlerchr Siedlerchr merged commit 35d995a into main Sep 21, 2022
@Siedlerchr Siedlerchr deleted the improvePdfIndexing branch September 21, 2022 20:11
Siedlerchr added a commit to LIM0000/jabref that referenced this pull request Oct 3, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-for-issue-8189
f068634 
* upstream/main: (27 commits)
  Bump slf4j-api from 2.0.2 to 2.0.3 (JabRef#9207)
  Bump slf4j-api from 2.0.2 to 2.0.3 in /buildSrc (JabRef#9211)
  Add mappings on ModsImporter.java (JabRef#9193)
  Improve installation of java 18 in devcontainer (JabRef#9197)
  Fix missing title for "customize entry types" (JabRef#9198) (JabRef#9201)
  Squashed 'buildres/csl/csl-locales/' changes from b2afeb4d87..cb98d36691
  Squashed 'buildres/csl/csl-styles/' changes from 201e022..7bde3e4
  "Capitalize" capitalizes words after hyphens (JabRef#9186)
  Observable Preferences O (Language and FileHistory) (JabRef#9173)
  Fix jakarta annotation missing (JabRef#9183)
  Bump junit-platform-launcher from 1.9.0 to 1.9.1 (JabRef#9177)
  Bump WyriHaximus/github-action-wait-for-status from 1.6 to 1.7.1 (JabRef#9178)
  Bump junit-jupiter from 5.9.0 to 5.9.1 (JabRef#9180)
  Bump checkstyle from 10.3.3 to 10.3.4 (JabRef#9179)
  Bump slf4j-api from 2.0.1 to 2.0.2 (JabRef#9181)
  Bump slf4j-api from 2.0.1 to 2.0.2 in /buildSrc (JabRef#9182)
  Remove Java Flight Recorder (JabRef#9174)
  Fixes fetcher tests (JabRef#9175)
  Update afterburner to jakarta (JabRef#9168)
  Improve startup-behavior of pdf indexer (JabRef#9166)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
component: search status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Library modification appearently triggers reindexing of all PDFs
2 participants
@btut @Siedlerchr