Update to jfx 19

build.gradle

@@ -99,7 +99,7 @@ dependencyLocking {
 }
 
 javafx {
-    version = "18.0.2"
+    version = "19"
     modules = [ 'javafx.controls', 'javafx.fxml', 'javafx.web', 'javafx.swing' ]
 }
 
@@ -167,7 +167,7 @@ dependencies {
     implementation 'org.kordamp.ikonli:ikonli-materialdesign2-pack:12.3.1'
     implementation 'com.github.sialcasa.mvvmFX:mvvmfx-validation:f195849ca9' //jitpack
     implementation 'de.saxsys:mvvmfx:1.8.0'
-    implementation 'com.tobiasdiez:easybind:2.2'
+    implementation 'com.tobiasdiez:easybind:2.2.1-SNAPSHOT'
     implementation 'org.fxmisc.flowless:flowless:0.6.10'
     implementation 'org.fxmisc.richtext:richtextfx:0.10.9'
     implementation group: 'org.glassfish.hk2.external', name: 'jakarta.inject', version: '2.6.1'

src/main/java/org/jabref/gui/StateManager.java

@@ -68,7 +68,7 @@ public class StateManager {
     private final ObjectProperty<LastAutomaticFieldEditorEdit> lastAutomaticFieldEditorEdit = new SimpleObjectProperty<>();
 
     public StateManager() {
-        activeGroups.bind(Bindings.valueAt(selectedGroups, activeDatabase.orElse(null)));
+        activeGroups.bind(Bindings.valueAt(selectedGroups, activeDatabase.orElseOpt(null)));
     }
 
     public ObservableList<SidePaneType> getVisibleSidePaneComponents() {

src/main/java/org/jabref/gui/actions/ActionHelper.java

@@ -58,13 +58,13 @@ public static BooleanExpression isAnyFieldSetForSelectedEntry(List<Field> fields
                                                 .mapObservable(entry -> Bindings.createBooleanBinding(() -> {
                                                     return entry.getFields().stream().anyMatch(fields::contains);
                                                 }, entry.getFieldsObservable()))
-                                                .orElse(false);
+                                                .orElseOpt(false);
         return BooleanExpression.booleanExpression(fieldsAreSet);
     }
 
     public static BooleanExpression isFilePresentForSelectedEntry(StateManager stateManager, PreferencesService preferencesService) {
         ObservableList<BibEntry> selectedEntries = stateManager.getSelectedEntries();
-        Binding<Boolean> fileIsPresent = EasyBind.valueAt(selectedEntries, 0).map(entry -> {
+        Binding<Boolean> fileIsPresent = EasyBind.valueAt(selectedEntries, 0).mapOpt(entry -> {
             List<LinkedFile> files = entry.getFiles();
 
             if ((entry.getFiles().size() > 0) && stateManager.getActiveDatabase().isPresent()) {
@@ -80,7 +80,7 @@ public static BooleanExpression isFilePresentForSelectedEntry(StateManager state
             } else {
                 return false;
             }
-        }).orElse(false);
+        }).orElseOpt(false);
 
         return BooleanExpression.booleanExpression(fileIsPresent);
     }

src/main/java/org/jabref/gui/groups/GroupTreeView.java

@@ -263,8 +263,8 @@ private void initialize() {
             // Add context menu (only for non-null items)
             row.contextMenuProperty().bind(
                     EasyBind.wrapNullable(row.itemProperty())
-                            .map(this::createContextMenuForGroup)
-                            .orElse((ContextMenu) null));
+                            .mapOpt(this::createContextMenuForGroup)
+                            .orElseOpt((ContextMenu) null));
             row.addEventFilter(MouseEvent.MOUSE_PRESSED, event -> {
                 if (event.getButton() == MouseButton.SECONDARY) {
                     // Prevent right-click to select group
@@ -357,7 +357,7 @@ private void updateSelection(List<TreeItem<GroupNodeViewModel>> newSelectedGroup
         if ((newSelectedGroups == null) || newSelectedGroups.isEmpty()) {
             viewModel.selectedGroupsProperty().clear();
         } else {
-            List<GroupNodeViewModel> list = newSelectedGroups.stream().filter(model -> model != null && !(model.getValue().getGroupNode().getGroup() instanceof AllEntriesGroup)).map(TreeItem::getValue).collect(Collectors.toList());
+            List<GroupNodeViewModel> list = newSelectedGroups.stream().filter(model -> (model != null) && !(model.getValue().getGroupNode().getGroup() instanceof AllEntriesGroup)).map(TreeItem::getValue).collect(Collectors.toList());
             viewModel.selectedGroupsProperty().setAll(list);
         }
     }
@@ -500,7 +500,7 @@ public void expandGroup(TreeItem<GroupNodeViewModel> treeItem) {
                 return;
             }
 
-            if (System.currentTimeMillis() - this.dragStarted > DRAG_TIME_BEFORE_EXPANDING_MS) {
+            if ((System.currentTimeMillis() - this.dragStarted) > DRAG_TIME_BEFORE_EXPANDING_MS) {
                 // expand or collapse the tree item and reset the time
                 this.dragStarted = System.currentTimeMillis();
                 this.draggedItem.setExpanded(!this.draggedItem.isExpanded());

src/main/java/org/jabref/gui/maintable/BibEntryTableViewModel.java

@@ -49,7 +49,7 @@ public BibEntryTableViewModel(BibEntry entry, BibDatabaseContext bibDatabaseCont
         this.entry = entry;
         this.fieldValueFormatter = fieldValueFormatter;
 
-        this.linkedFiles = getField(StandardField.FILE).map(FileFieldParser::parse).orElse(Collections.emptyList());
+        this.linkedFiles = getField(StandardField.FILE).mapOpt(FileFieldParser::parse).orElseOpt(Collections.emptyList());
         this.linkedIdentifiers = createLinkedIdentifiersBinding(entry);
         this.matchedGroups = createMatchedGroupsBinding(bibDatabaseContext, entry);
         this.bibDatabaseContext = bibDatabaseContext;
@@ -107,7 +107,7 @@ public ObservableValue<Optional<SpecialFieldValueViewModel>> getSpecialField(Spe
         if (value != null) {
             return value;
         } else {
-            value = getField(field).flatMap(fieldValue -> field.parseValue(fieldValue).map(SpecialFieldValueViewModel::new));
+            value = getField(field).flatMapOpt(fieldValue -> field.parseValue(fieldValue).map(SpecialFieldValueViewModel::new));
             specialFieldValues.put(field, value);
             return value;
         }

src/main/java/org/jabref/gui/util/OptionalObjectProperty.java

@@ -25,8 +25,8 @@ public static <T> OptionalObjectProperty<T> empty() {
      * Returns a new ObservableValue that holds the value held by this
      * ObservableValue, or {@code other} when this ObservableValue is empty.
      */
-    public ObjectBinding<T> orElse(T other) {
-        return new PreboundBinding<T>(this) {
+    public ObjectBinding<T> orElseOpt(T other) {
+        return new PreboundBinding<>(this) {
             @Override
             protected T computeValue() {
                 return OptionalObjectProperty.this.getValue().orElse(other);

src/main/java/org/jabref/model/entry/BibEntry.java

@@ -298,7 +298,7 @@ private Optional<String> genericGetResolvedFieldOrAlias(Field field, BibDatabase
             }
         }
 
-        return (database == null || result.isEmpty()) ?
+        return ((database == null) || result.isEmpty()) ?
                 result :
                 Optional.of(database.resolveForStrings(result.get()));
     }
@@ -970,7 +970,7 @@ public Optional<Month> getMonth() {
 
     public OptionalBinding<String> getFieldBinding(Field field) {
         if ((field == InternalField.TYPE_HEADER) || (field == InternalField.OBSOLETE_TYPE_HEADER)) {
-            return EasyBind.wrapNullable(type).map(EntryType::getDisplayName);
+            return EasyBind.wrapNullable(type).mapOpt(EntryType::getDisplayName);
         }
         return EasyBind.valueAt(fields, field);
     }