Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception that occurs when saving name formatters #9121

Merged
merged 2 commits into from
Sep 2, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
- We fixed a bug where updating group view mode (intersection or union) requires re-selecting groups to take effect. [#6998](https://github.com/JabRef/jabref/issues/6998)
- We fixed a bug that prevented external group metadata changes from being merged. [#8873](https://github.com/JabRef/jabref/issues/8873)
- We fixed the shared database opening dialog to remember autosave folder and tick. [#7516](https://github.com/JabRef/jabref/issues/7516)
- We fixed an issue where name formatter could not be saved. [#9120](https://github.com/JabRef/jabref/issues/9120)

### Removed

Expand Down
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
package org.jabref.logic.layout.format;

import java.util.List;

import javafx.collections.FXCollections;
import javafx.collections.ObservableList;

import java.util.List;

public class NameFormatterPreferences {

private final ObservableList<String> nameFormatterKey;
private final ObservableList<String> nameFormatterValue;

public NameFormatterPreferences(List<String> nameFormatterKey, List<String> nameFormatterValue) {
this.nameFormatterKey = FXCollections.observableList(nameFormatterKey);
this.nameFormatterValue = FXCollections.observableList(nameFormatterValue);
this.nameFormatterKey = FXCollections.observableArrayList(nameFormatterKey);
this.nameFormatterValue = FXCollections.observableArrayList(nameFormatterValue);
}

public ObservableList<String> getNameFormatterKey() {
Expand Down