Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan to fix the problem:A particular empty entry can be added without warning message. #8941

Closed
wants to merge 1 commit into from

Conversation

xiaoyanghuo
Copy link

@xiaoyanghuo xiaoyanghuo commented Jun 30, 2022

This is group14 from the course "Open Source Development".

We are planning to fix #8645, which shows that a particular empty entry can be added without warning message.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@xiaoyanghuo xiaoyanghuo changed the title Create group14.md Plan to fix the problem:A particular empty entry can be added without warning message. Jun 30, 2022
@ThiloteE
Copy link
Member

I edited your introduction commit message to conform to GitHubs syntax of linking pull-requests to issues:

  • Before: "We are planning to fix the issue https://github.com/JabRef/jabref/issues/8645" (does not link the pull-request)
  • After: "We are planning to fix #8645 (links the pull-request)

@Siedlerchr
Copy link
Member

Please do your testing on your own Repos!

@Siedlerchr Siedlerchr closed this Jul 1, 2022
@xiaoyanghuo xiaoyanghuo deleted the group14-patch-1-1 branch July 12, 2022 15:30
@xiaoyanghuo xiaoyanghuo restored the group14-patch-1-1 branch July 12, 2022 15:31
@xiaoyanghuo xiaoyanghuo deleted the group14-patch-1-1 branch July 12, 2022 15:31
@xiaoyanghuo xiaoyanghuo restored the group14-patch-1-1 branch July 15, 2022 09:59
@xiaoyanghuo xiaoyanghuo deleted the group14-patch-1-1 branch July 15, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An empty entry can still be added without warning message (and lead to an error when compiling)
3 participants