Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework IACR fetcher #8904

Merged
merged 4 commits into from
Jun 20, 2022
Merged

Rework IACR fetcher #8904

merged 4 commits into from
Jun 20, 2022

Conversation

LIM0000
Copy link
Contributor

@LIM0000 LIM0000 commented Jun 15, 2022 •
edited
Loading

Previous discussion about reworking IACR fetcher #8876

We need to rewrite the IacrEprintFetcher to rely on https://eprint.iacr.org/ID (example: https://eprint.iacr.org/2022/674) only.

Proposed solution

Fixes #8876

  1. CITATION_URL_PREFIX changes from https://eprint.iacr.org/eprint-bin/cite.pl?entry= to https://eprint.iacr.org/
  2. new variable VERSION_URL_PREFIX = https://eprint.iacr.org/archive/versions/ to retrieve latest version
    333
  3. Date field is retrieve from the latest date in History section
    222

Output example

For https://eprint.iacr.org/2022/674
111

PR checklist:

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@LIM0000 LIM0000 changed the title Rework ICAR fetcher Rework IACR fetcher Jun 15, 2022
@Siedlerchr
Copy link
Member

Can you please fix the fetcher tests for the fetcher (they only run locally)?
Seems to be just some minor changes to the bibtex
grafik

Otherwise lgtm

@LIM0000
Copy link
Contributor Author

LIM0000 commented Jun 19, 2022

Hi @Siedlerchr , I have updated the IACR fetcher test cases in latest commit.
Cheers.

@LIM0000 LIM0000 marked this pull request as ready for review June 19, 2022 22:22
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 20, 2022
@calixtus calixtus merged commit 41edd28 into JabRef:main Jun 20, 2022
@calixtus
Copy link
Member

Thanks for your contribution to JabRef. We already saw that you created multiple PR. We are very happy that you like working on JabRef and are excited to see your other work!

Siedlerchr added a commit that referenced this pull request Jun 23, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into controlsfx-tags
2e236f0 
* upstream/main: (27 commits)
  Add gitpod config (#8921)
  Fix javafx version not displayed in About Dialog (#8918)
  Redesign "Manage field names & content" dialog (#8892)
  Rework IACR fetcher (#8904)
  Bump h2-mvstore from 2.1.212 to 2.1.214 in /buildSrc (#8915)
  Bump unoloader from 7.3.3 to 7.3.4 (#8912)
  Bump libreoffice from 7.3.3 to 7.3.4 (#8913)
  Bump tika-core from 2.4.0 to 2.4.1 (#8914)
  Bump org.eclipse.jgit from 6.1.0.202203080745-r to 6.2.0.202206071550-r (#8916)
  Squashed 'buildres/csl/csl-styles/' changes from e740261..845dee0 (#8903)
  Bump flowless from 0.6.9 to 0.6.10 (#8898)
  Bump postgresql from 42.3.5 to 42.4.0 (#8900)
  Bump mockito-core from 4.6.0 to 4.6.1 (#8899)
  Bump antlr-runtime from 3.5.2 to 3.5.3 (#8897)
  Update to MADR 3.0.0-beta.2 (#8896)
  Increase the network connection timeout and improve error message (#8894)
  Fix linux terminal opening process error (#8891)
  Fix exception if linked file has masked umlauts / invalid characters in path (#8851)
  Remove obsolte CHANGELOG.md entry
  Revert "Fix right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected (#8821)"
  ...

# Conflicts:
#	build.gradle
Siedlerchr added a commit to prashant1712/jabref that referenced this pull request Jun 27, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into unlinkedFiles#373
463d3d8 
* upstream/main:
  Try to  make reproducible builds (JabRef#8925)
  Link to new board (and refine text)
  Pass the data as a string (JabRef#8923)
  Add IntelliJ plugins to Gitpod configuration
  Add gradle support
  Fix extension name
  Remove obsolete closing bracket
  Add gitpod config (JabRef#8921)
  Fix javafx version not displayed in About Dialog (JabRef#8918)
  Redesign "Manage field names & content" dialog (JabRef#8892)
  Rework IACR fetcher (JabRef#8904)
  Bump h2-mvstore from 2.1.212 to 2.1.214 in /buildSrc (JabRef#8915)
  Bump unoloader from 7.3.3 to 7.3.4 (JabRef#8912)
  Bump libreoffice from 7.3.3 to 7.3.4 (JabRef#8913)
  Bump tika-core from 2.4.0 to 2.4.1 (JabRef#8914)
  Bump org.eclipse.jgit from 6.1.0.202203080745-r to 6.2.0.202206071550-r (JabRef#8916)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
fetcher status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rework ICAR Fetcher
4 participants
@LIM0000 @Siedlerchr @calixtus @ThiloteE