Refactor of DOI import failure dialog, import format reader and clipboard manager

src/main/java/org/jabref/gui/mergeentries/FetchAndMergeEntry.java

@@ -76,7 +76,7 @@ public void fetchAndMerge(BibEntry entry, List<Field> fields) {
                                   })
                                   .onFailure(exception -> {
                                       LOGGER.error("Error while fetching bibliographic information", exception);
-                                      String localMessage = exception.getCause().getLocalizedMessage();
+                                      String localMessage = exception.getLocalizedMessage();
                                       // client error
                                       if (localMessage.startsWith("Client")) {
                                           dialogService.showInformationDialogAndWait(Localization.lang("Lookup DOI"), Localization.lang("No DOI data was found"));

src/main/java/org/jabref/logic/importer/fetcher/DoiFetcher.java

@@ -1,5 +1,6 @@
 package org.jabref.logic.importer.fetcher;
 
+import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.net.URL;
 import java.util.Collections;
@@ -72,7 +73,6 @@ public Optional<BibEntry> performSearchById(String identifier) throws FetcherExc
                     return new Medra().performSearchById(identifier);
                 }
                 URL doiURL = new URL(doi.get().getURIAsASCIIString());
-
                 // BibTeX data
                 URLDownload download = getUrlDownload(doiURL);
                 download.addHeader("Accept", MediaTypes.APPLICATION_BIBTEX);
@@ -81,7 +81,12 @@ public Optional<BibEntry> performSearchById(String identifier) throws FetcherExc
                     bibtexString = download.asString();
                 } catch (IOException e) {
                     // an IOException will be thrown if download is unable to download from the doiURL
-                    throw new FetcherException(Localization.lang("No DOI data exists"), e);
+                    // dispatch the IOException
+                    if (e instanceof FileNotFoundException) {
+                        throw new FetcherException(Localization.lang("Client Error"), e);
+                    } else {
+                        throw new FetcherException(Localization.lang("Server Error"), e);
+                    }
                 }
 
                 // BibTeX entry
@@ -109,6 +114,17 @@ public Optional<BibEntry> performSearchById(String identifier) throws FetcherExc
         }
     }
 
+    /**
+     * Returns client error or server error according to the message
+     *
+     * @param exception the IOException
+     */
+    private String dispatchIOException(IOException exception) {
+        String classification = "Client Error";
+
+        return classification;
+    }
+
     private void doPostCleanup(BibEntry entry) {
         new FieldFormatterCleanup(StandardField.PAGES, new NormalizePagesFormatter()).cleanup(entry);
         new FieldFormatterCleanup(StandardField.URL, new ClearFormatter()).cleanup(entry);

src/main/java/org/jabref/logic/net/URLDownload.java

@@ -40,7 +40,6 @@
 import javax.net.ssl.TrustManager;
 import javax.net.ssl.X509TrustManager;
 
-import org.jabref.logic.l10n.Localization;
 import org.jabref.logic.util.io.FileUtil;
 import org.jabref.model.util.FileHelper;
 
@@ -361,14 +360,6 @@ private URLConnection openConnection() throws IOException {
                     connection = new URLDownload(newUrl).openConnection();
                 }
             }
-            // status code 4xx
-            if (status > HttpURLConnection.HTTP_BAD_REQUEST && status < HttpURLConnection.HTTP_INTERNAL_ERROR) {
-                throw new IOException(Localization.lang("Client Error %0", status));
-
-                // status code 5xx
-            } else if (status >= HttpURLConnection.HTTP_INTERNAL_ERROR) {
-                throw new IOException(Localization.lang("Server Error %0", status));
-            }
         }
 
         // this does network i/o: GET + read returned headers

src/main/resources/l10n/JabRef_en.properties

@@ -580,8 +580,6 @@ No\ journal\ names\ could\ be\ abbreviated.=No journal names could be abbreviate
 
 No\ journal\ names\ could\ be\ unabbreviated.=No journal names could be unabbreviated.
 
-No\ DOI\ data\ exists=No DOI data exists
-
 not=not
 
 not\ found=not found
@@ -2488,8 +2486,8 @@ Success\!\ Finished\ writing\ metadata.=Success! Finished writing metadata.
 Custom\ API\ key=Custom API key
 Check\ %0\ API\ Key\ Setting=Check %0 API Key Setting
 
-Client\ Error\ %0=Client Error %0
+Client\ Error=Client Error
 DOI\ server\ not\ available=DOI server not available
 Lookup\ DOI=Lookup DOI
 No\ DOI\ data\ was\ found=No DOI data was found
-Server\ Error\ %0=Server Error %0
+Server\ Error=Server Error

src/test/java/org/jabref/logic/importer/fetcher/DoiFetcherTest.java

@@ -15,6 +15,7 @@
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.mockito.Mockito.mock;
 
 @FetcherTest
@@ -117,6 +118,20 @@ public void testPerformSearchInvalidDOI() {
         assertThrows(FetcherException.class, () -> fetcher.performSearchById("10.1002/9781118257517F"));
     }
 
+    // test invalid DOI client error message "Client Error"
+    @Test
+    public void testPerformSearchInvalidDOIClientErrorMessage1() {
+        FetcherException exception = assertThrows(FetcherException.class, () -> fetcher.performSearchById("10.1002/9781118257517F"));
+        assertTrue(exception.getLocalizedMessage().contentEquals("Client Error"));
+    }
+
+    // test invalid DOI client error message "Client Error"
+    @Test
+    public void testPerformSearchInvalidDOIClientErrorMessage2() {
+        FetcherException exception = assertThrows(FetcherException.class, () -> fetcher.performSearchById("10.1002/9781517F"));
+        assertTrue(exception.getLocalizedMessage().contentEquals("Client Error"));
+    }
+
     @Test
     public void testPerformSearchNonTrimmedDOI() throws FetcherException {
         Optional<BibEntry> fetchedEntry = fetcher.performSearchById("http s://doi.org/ 10.1109 /ICWS .2007.59 ");

src/test/java/org/jabref/logic/net/URLDownloadTest.java

@@ -28,22 +28,6 @@ public void testStringDownloadWithSetEncoding() throws IOException {
         assertTrue(dl.asString().contains("Google"), "google.com should contain google");
     }
 
-    // test client error 404
-    @Test
-    public void testStringDownloadThrowClientError() throws IOException {
-        URLDownload dl = new URLDownload(new URL("http://httpstat.us/404"));
-        IOException exception = assertThrows(IOException.class, dl::asString);
-        assertTrue(exception.getLocalizedMessage().contentEquals("Client Error 404"), "Should be Client Error.");
-    }
-
-    // test server error 503
-    @Test
-    public void testStringDownloadThrowServerError() throws IOException {
-        URLDownload dl = new URLDownload(new URL("http://httpstat.us/503"));
-        IOException exception = assertThrows(IOException.class, dl::asString);
-        assertTrue(exception.getLocalizedMessage().contentEquals("Server Error 503"), "Should be Server Error.");
-    }
-
     @Test
     public void testStringDownload() throws IOException {
         URLDownload dl = new URLDownload(new URL("http://www.google.com"));