Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cleanup actions: "Prepare for LaTeX" and "Prepare for BibTeX" #8735

Closed
wants to merge 1 commit into from

Conversation

zkl-ai
Copy link
Contributor

@zkl-ai zkl-ai commented Apr 30, 2022

Fixes #8672

Result:
image

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Contributor Author

@zkl-ai zkl-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename cleanup actions: "Make LaTeX ready" and "Make BibTeX ready"

@ThiloteE ThiloteE changed the title Rename cleanup actions: "Make LaTeX ready" and "Make BibTeX ready" Rename cleanup actions: "Prepare for LaTeX" and "Prepare for BibTeX" Apr 30, 2022
@ThiloteE ThiloteE added cleanup-ops unicode unicode related issues labels Apr 30, 2022
@ThiloteE
Copy link
Member

Documentation needs to be changed here also: https://docs.jabref.org/finding-sorting-and-cleaning-entries/saveactions#latex-cleanup

@ThiloteE
Copy link
Member

Also: Add to documentation of Prepare for LaTeX: Cleanup (see here): Single $ characters will not be removed from the entry. This allows users to denote the start and end of LaTeX math-mode in their bibliography. One enters math mode by typing a dollar sign $, and one leaves math mode by typing another dollar sign $

@zkl-ai
Copy link
Contributor Author

zkl-ai commented Apr 30, 2022

Also: Add to documentation of Prepare for LaTeX: Cleanup (see here): Single $ characters will not be removed from the entry. This allows users to denote the start and end of LaTeX math-mode in their bibliography. One enters math mode by typing a dollar sign $, and one leaves math mode by typing another dollar sign $

Ok. I will change it later!

@Siedlerchr
Copy link
Member

Please have a look at the failing unit tests. You need to adjust the l10n https://devdocs.jabref.org/getting-into-the-code/code-howtos.html#using-localization-correctly

@Siedlerchr Siedlerchr added the status: changes required Pull requests that are not yet complete label May 2, 2022
@zkl-ai
Copy link
Contributor Author

zkl-ai commented May 3, 2022

Please have a look at the failing unit tests. You need to adjust the l10n https://devdocs.jabref.org/getting-into-the-code/code-howtos.html#using-localization-correctly

Ok, I'm looking for it. Thank you for your warning.

@Siedlerchr
Copy link
Member

Siedlerchr commented May 12, 2022

It seems like you didn't read through it correctly. You actually need to change it in the Code and in the L10n file. And you cannot just rename the values. The keys and the values in the l10n have to be the same.
Sorry, but this PR makes no sense as is.

@Siedlerchr Siedlerchr closed this May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup-ops status: changes required Pull requests that are not yet complete unicode unicode related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename cleanup actions: "Prepare for LaTeX" and "Prepare for BibTeX"
3 participants