Resolve File Creation Issue With Medline/PubMed

[addak]

Issue : Due to the Fetcher Name being "Medline/PubMed", File creation fails as Medline is treated as a Directory and since It isn't created, the issue is observable.
Fixes #8455

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[addak]

@Siedlerchr A better fix would be to change the name in MedlineFetcher from "Medline/PubMed" to some other appropriate one imho.

public class MedlineFetcher implements IdBasedParserFetcher, SearchBasedFetcher 
.
.
.
 @Override
    public String getName() {
        return "Medline/PubMed";  <--- Change the name
    }

[Siedlerchr]

The fetcher has been named like that for ages. And there can always be a fetcher with a weird name, so this should be fine,

[addak]

@Siedlerchr Please review!

[Siedlerchr]

In general, it is better you compare two collections directly, this makes it easier to spot differences in case of failure.
e.g. you have on the one hand:
expectedFetcherNames = LIst.of(.......)
actualFetcherNames = result.stream.map(Fetcher::getName).toCollection...
assertEquals(expectedFetcherNames,

[Siedlerchr]

I wonder if it makes sense to convert this test to a parameterized unit test.

[addak]

We would need multiple "study.yml" files, so... yeah, let me know what you think would be better

[Siedlerchr]

overall lgtm, just some ideas for improvement.

[Siedlerchr]

Suggested change

	- We fixed an issue where folder creation during systemic review failed due illegal fetcher name. [#8552](https://github.com/JabRef/jabref/pull/8552)
	- We fixed an issue where folder creation during systemic literature review failed due to an illegal fetcher name. [#8552](https://github.com/JabRef/jabref/pull/8552)

[addak]

Hi
Could you please tell me what needs to be properly formatted to resolve the format issue with checkstyle?

 @Test
    public void testWhetherAllFilesAreCreated() throws Exception {
        setUp();
        Crawler testCrawler = new Crawler(getPathToStudyDefinitionFile(), gitHandler, generalPreferences, importFormatPreferences, savePreferences, entryTypesManager, new DummyFileUpdateMonitor());

        testCrawler.performCrawl();

        assertTrue(Files.exists(Path.of(tempRepositoryDirectory.toString(), hashCodeQuantum + " - Quantum")));
        assertTrue(Files.exists(Path.of(tempRepositoryDirectory.toString(), hashCodeCloudComputing + " - Cloud Computing")));

        List<String> filesToAssert = List.of("ArXiv.bib", "Springer.bib", "result.bib", "Medline_PubMed.bib");
        filesToAssert.forEach(
                fileName -> {
                    assertTrue(Files.exists(Path.of(tempRepositoryDirectory.toString(), hashCodeQuantum + " - Quantum", fileName)));
                    assertTrue(Files.exists(Path.of(tempRepositoryDirectory.toString(), hashCodeCloudComputing + " - Cloud Computing", fileName)));
                });
        assertTrue(Files.exists(Path.of(tempRepositoryDirectory.toString(), "studyResult.bib")));
    }

[Siedlerchr]

@addak The whitepsace was tricky, it was the last element int the list.