-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to jakarta xml everywhere and update PDFbox #8521
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [jakarta.activation-api](https://github.com/eclipse-ee4j/jaf) from 1.2.1 to 2.1.0. - [Release notes](https://github.com/eclipse-ee4j/jaf/releases) - [Commits](jakartaee/jaf-api@1.2.1...2.1.0) --- updated-dependencies: - dependency-name: jakarta.activation:jakarta.activation-api dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Siedlerchr
changed the title
Update tojakarta
Update to jakarta xml everywhere and update PDFbox
Feb 21, 2022
Siedlerchr
added
the
status: ready-for-review
Pull Requests that are ready to be reviewed by the maintainers
label
Feb 21, 2022
TODO: Needs testing of the binaries. If they still work with import/export in jpackage |
calixtus
reviewed
Feb 22, 2022
calixtus
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise looks good to me!
tested locally using jpackage, seems to work fine. |
Siedlerchr
added a commit
that referenced
this pull request
Mar 7, 2022
* upstream/main: Bump guava from 31.0.1-jre to 31.1-jre (#8543) Bump org.beryx.jlink from 2.24.4 to 2.25.0 (#8548) Bump postgresql from 42.3.2 to 42.3.3 (#8546) Bump richtextfx from 0.10.7 to 0.10.9 (#8547) Bump archunit-junit5-engine from 0.22.0 to 0.23.1 (#8545) Bump actions/checkout from 2 to 3 (#8542) Squashed 'buildres/csl/csl-styles/' changes from eb97405..8f69d4e Bump classgraph from 4.8.139 to 4.8.141 (#8535) Bump archunit-junit5-api from 0.22.0 to 0.23.1 (#8536) issue(8448): allow URL with + sign in entry tabs (#8508) Add initial telemetry development documentation (#8530) Add existing "Remote storage" to index Disable telemetry client due to incompatibilites with jakarta (#8526) Update to jakarta xml everywhere and update PDFbox (#8521) Bump flexmark-ext-gfm-tasklist from 0.62.2 to 0.64.0 (#8515) Bump xmlunit-core from 2.8.4 to 2.9.0 (#8519) Bump org.openjfx.javafxplugin from 0.0.11 to 0.0.12 (#8518) Bump mockito-core from 4.3.0 to 4.3.1 (#8520)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally managed to upgrade to jakarta.xml stuff :)
Man is that complicated with all the jaxb stuff
@koppor I also refactored the XMP tests
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)