Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to jakarta xml everywhere and update PDFbox #8521

Merged
merged 9 commits into from
Feb 22, 2022
Merged

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Feb 21, 2022

I finally managed to upgrade to jakarta.xml stuff :)
Man is that complicated with all the jaxb stuff

@koppor I also refactored the XMP tests

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

dependabot bot and others added 4 commits February 21, 2022 14:09
Bumps [jakarta.activation-api](https://github.com/eclipse-ee4j/jaf) from 1.2.1 to 2.1.0.
- [Release notes](https://github.com/eclipse-ee4j/jaf/releases)
- [Commits](jakartaee/jaf-api@1.2.1...2.1.0)

---
updated-dependencies:
- dependency-name: jakarta.activation:jakarta.activation-api
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
…akarta.activation-jakarta.activation-api-2.1.0

* upstream/main:
  Bump xmlunit-core from 2.8.4 to 2.9.0 (#8519)
  Bump org.openjfx.javafxplugin from 0.0.11 to 0.0.12 (#8518)
  Bump mockito-core from 4.3.0 to 4.3.1 (#8520)
@Siedlerchr Siedlerchr changed the title Update tojakarta Update to jakarta xml everywhere and update PDFbox Feb 21, 2022
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 21, 2022
@Siedlerchr
Copy link
Member Author

TODO: Needs testing of the binaries. If they still work with import/export in jpackage

@Siedlerchr Siedlerchr mentioned this pull request Feb 22, 2022
2 tasks
Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise looks good to me!

@Siedlerchr
Copy link
Member Author

tested locally using jpackage, seems to work fine.

@Siedlerchr Siedlerchr merged commit d98a603 into main Feb 22, 2022
@Siedlerchr Siedlerchr deleted the updateTojakarta branch February 22, 2022 18:46
Siedlerchr added a commit that referenced this pull request Mar 7, 2022
* upstream/main:
  Bump guava from 31.0.1-jre to 31.1-jre (#8543)
  Bump org.beryx.jlink from 2.24.4 to 2.25.0 (#8548)
  Bump postgresql from 42.3.2 to 42.3.3 (#8546)
  Bump richtextfx from 0.10.7 to 0.10.9 (#8547)
  Bump archunit-junit5-engine from 0.22.0 to 0.23.1 (#8545)
  Bump actions/checkout from 2 to 3 (#8542)
  Squashed 'buildres/csl/csl-styles/' changes from eb97405..8f69d4e
  Bump classgraph from 4.8.139 to 4.8.141 (#8535)
  Bump archunit-junit5-api from 0.22.0 to 0.23.1 (#8536)
  issue(8448): allow URL with + sign in entry tabs (#8508)
  Add initial telemetry development documentation (#8530)
  Add existing "Remote storage" to index
  Disable telemetry client due to incompatibilites with jakarta (#8526)
  Update to jakarta xml everywhere and update PDFbox (#8521)
  Bump flexmark-ext-gfm-tasklist from 0.62.2 to 0.64.0 (#8515)
  Bump xmlunit-core from 2.8.4 to 2.9.0 (#8519)
  Bump org.openjfx.javafxplugin from 0.0.11 to 0.0.12 (#8518)
  Bump mockito-core from 4.3.0 to 4.3.1 (#8520)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants