Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Groups interface into Groups #8449

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Rename Groups interface into Groups #8449

merged 2 commits into from
Jan 19, 2022

Conversation

mlep
Copy link
Contributor

@mlep mlep commented Jan 19, 2022 •
edited by Siedlerchr
Loading

Fixes #8447.
So easy?!?

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member

You need to edit it here as well https://github.com/JabRef/jabref/blob/main/src/main/resources/l10n/JabRef_en.properties

@calixtus
Copy link
Member

Why is the l10n test not failing?

@calixtus
Copy link
Member

Bug triangulation:

  • The consistency test should fail if the l10n-key is removed in the code but not in the language resource file.
  • "Groups interface" is included in JabRef_en.properties but in IntelliJ the key in the resourcefile is not recognized as used.
  • The language key is used in an enum ub StabdardActions

@Siedlerchr
Copy link
Member

Siedlerchr commented Jan 19, 2022 •
edited
Loading

@calixtus It is failing: But I guess we have the word "Groups" already in the files

LocalizationConsistencyTest > findObsoleteLocalizationKeys() FAILED
org.opentest4j.AssertionFailedError: Obsolete keys found in language properties file:

Groups interface

1. CHECK IF THE KEY IS REALLY NOT USED ANYMORE
2. REMOVE THESE FROM THE ENGLISH LANGUAGE FILE
 ==> expected: <[]> but was: <[Groups interface]>

@mlep
Copy link
Contributor Author

mlep commented Jan 19, 2022 •
edited
Loading

So, yeah, not so easy... 😢
Do not hesitate to kill my PR if it's messy.

@calixtus
Copy link
Member

Must have overlooked it...
Thanks for the contribution, merging now!

@calixtus calixtus closed this Jan 19, 2022
@calixtus calixtus reopened this Jan 19, 2022
@calixtus calixtus merged commit 62e4ec4 into JabRef:main Jan 19, 2022
@calixtus
Copy link
Member

Why messy? It was perfectly fine!

@mlep
Copy link
Contributor Author

mlep commented Jan 19, 2022

Thanks. When I saw it was failing and led to discussion, I thought it was a dumb action from me.
Considering it was a success, I may try again. 😉

@mlep mlep deleted the patch-2 branch January 19, 2022 13:49
@calixtus
Copy link
Member

You should absolutley! 👍

Siedlerchr added a commit that referenced this pull request Jan 21, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into checkKeygenOverwrite
f977d26 
* upstream/main: (50 commits)
  New Crowdin updates (#8451)
  Fix library tab exception when saving prefs (#8450)
  Rename Groups interface into Groups (#8449)
  New Crowdin updates (#8445)
  update snap url
  Update bug_report.yml for 5.5
  Show development information\n\n+semver: minor
  Release v5.5
  Update journal abbrev list
  New Crowdin updates (#8439)
  Refresh example styles
  Squashed 'buildres/csl/csl-styles/' changes from 5563ccc..0237ae7
  Fixed add group button changing color after adding 10 groups (#8392)
  Bump slf4j-api from 2.0.0-alpha5 to 2.0.0-alpha6 in /buildSrc (#8438)
  Bump libreoffice from 7.2.3 to 7.2.5 (#8436)
  Bump org.openjfx.javafxplugin from 0.0.10 to 0.0.11 (#8437)
  Fix file directory preferences not respected (#8429)
  Refresh example styles
  Squashed 'buildres/csl/csl-locales/' changes from c38205618f..4a551a87c3
  Refresh example styles
  ...
Siedlerchr added a commit that referenced this pull request Jan 28, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into jdk17
84a2d78 
* upstream/main: (24 commits)
  Support CrossRef in CSL styles (#8454)
  Update FUNDING.yml (#8473)
  Update to Javafx 17.02 (#8470)
  Made search button in Web search wider. Also skewed side panel titles to the left (#8463)
  Bump h2-mvstore from 2.0.206 to 2.1.210 in /buildSrc (#8458)
  Bump mariadb-java-client from 2.7.4 to 2.7.5 (#8457)
  Bump com.github.andygoossens.modernizer from 1.6.1 to 1.6.2 (#8459)
  Bump mockito-core from 4.2.0 to 4.3.0 (#8460)
  Bump xmlunit-matchers from 2.8.3 to 2.8.4 (#8461)
  Improve error handling for browser extension (#8432)
  New Crowdin updates (#8451)
  Fix library tab exception when saving prefs (#8450)
  Rename Groups interface into Groups (#8449)
  New Crowdin updates (#8445)
  update snap url
  Update bug_report.yml for 5.5
  Show development information\n\n+semver: minor
  Release v5.5
  Update journal abbrev list
  New Crowdin updates (#8439)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Menu: Rename "Groups interface" into "Groups"
3 participants
@mlep @Siedlerchr @calixtus