Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"% Encoding" is written again in the case of non-UTF-8 #8424

Merged
merged 1 commit into from
Jan 13, 2022
Merged

"% Encoding" is written again in the case of non-UTF-8 #8424

merged 1 commit into from
Jan 13, 2022

Conversation

koppor
Copy link
Member

@koppor koppor commented Jan 13, 2022

Fixes #8417

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Siedlerchr
Siedlerchr approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 13, 2022
@Siedlerchr Siedlerchr merged commit b8f710d into main Jan 13, 2022
@Siedlerchr Siedlerchr deleted the fix-non-utf8 branch January 13, 2022 22:27
@koppor koppor mentioned this pull request Jan 13, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

% Encoding Comment wrongly dropped
2 participants
@koppor @Siedlerchr