Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #492: All text is copied if nothing is marked and preview of pa… #842

Merged
merged 2 commits into from
Feb 22, 2016

Conversation

oscargus
Copy link
Contributor

Fixed #492

When nothing is selected the whole field is copied. If the field is empty, the right click copy item is disabled.

Preview of text to be pasted in tool tip. Now maximum 20 characters. Should it be longer?

@oscargus oscargus added type: enhancement status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Feb 20, 2016
@oscargus oscargus force-pushed the betterfieldcopypaste branch 2 times, most recently from fb8b652 to 39322ec Compare February 20, 2016 10:13
@oscargus oscargus force-pushed the betterfieldcopypaste branch from 39322ec to 7575e55 Compare February 20, 2016 13:00
copyAct.setEnabled(cStat);

String data = ClipBoardManager.CLIPBOARD.getClipboardContents();
boolean pStat = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pStat? What does this mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming cStat means copy status pStat means paste status...

simonharrer added a commit that referenced this pull request Feb 22, 2016
Fixed #492: All text is copied if nothing is marked and preview of pa…
@simonharrer simonharrer merged commit 5e78a79 into JabRef:master Feb 22, 2016
@oscargus oscargus deleted the betterfieldcopypaste branch March 16, 2016 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants