Fix file-filter in XMP Export

CHANGELOG.md

@@ -73,6 +73,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
 - We fixed an issue where right-clicking on a tab and selecting close will close the focused tab even if it is not the tab we right-clicked [#8193](https://github.com/JabRef/jabref/pull/8193)
 - We fixed an issue where selecting a citation style in the preferences would sometimes produce an exception [#7860](https://github.com/JabRef/jabref/issues/7860)
 - We fixed an issue where an exception would occur when clicking on a DOI link in the preview pane [#7706](https://github.com/JabRef/jabref/issues/7706)
+- We fixed an issue where XMP and embedded BibTeX export would not work [#8278](https://github.com/JabRef/jabref/issues/8278)
 
 ### Removed
 

src/main/java/org/jabref/gui/actions/StandardActions.java

@@ -88,7 +88,7 @@ public enum StandardActions implements Action {
 
     PARSE_LATEX(Localization.lang("Search for citations in LaTeX files..."), IconTheme.JabRefIcons.LATEX_CITATIONS),
     NEW_SUB_LIBRARY_FROM_AUX(Localization.lang("New sublibrary based on AUX file") + "...", Localization.lang("New BibTeX sublibrary") + Localization.lang("This feature generates a new library based on which entries are needed in an existing LaTeX document."), IconTheme.JabRefIcons.NEW),
-    WRITE_METADATA_TO_PDF(Localization.lang("Write XMP metadata to PDFs"), Localization.lang("Will write XMP metadata to the PDFs linked from selected entries."), KeyBinding.WRITE_XMP),
+    WRITE_METADATA_TO_PDF(Localization.lang("Write metadata to PDF files"), Localization.lang("Will write metadata to the PDFs linked from selected entries."), KeyBinding.WRITE_METADATA_TO_PDF),
     START_NEW_STUDY(Localization.lang("Start new systematic literature review")),
     SEARCH_FOR_EXISTING_STUDY(Localization.lang("Perform search for existing systematic literature review")),
     OPEN_DATABASE_FOLDER(Localization.lang("Reveal in file explorer")),

src/main/java/org/jabref/gui/exporter/WriteMetadataToPdfAction.java

@@ -30,7 +30,6 @@
 import org.jabref.logic.bibtex.FieldWriterPreferences;
 import org.jabref.logic.exporter.EmbeddedBibFilePdfExporter;
 import org.jabref.logic.l10n.Localization;
-import org.jabref.logic.util.StandardFileType;
 import org.jabref.logic.util.io.FileUtil;
 import org.jabref.logic.xmp.XmpPreferences;
 import org.jabref.logic.xmp.XmpUtilWriter;
@@ -133,7 +132,7 @@ private void writeMetadata() {
                                     .map(file -> file.findIn(stateManager.getActiveDatabase().get(), filePreferences))
                                     .filter(Optional::isPresent)
                                     .map(Optional::get)
-                                    .filter(path -> StandardFileType.PDF.getExtensions().contains(FileUtil.getFileExtension(path)))
+                                    .filter(path -> FileUtil.isPDFFile(path))
                                     .collect(Collectors.toList());
 
             Platform.runLater(() -> optionsDialog.getProgressArea()

src/main/java/org/jabref/gui/keyboard/KeyBinding.java

@@ -106,7 +106,7 @@ public enum KeyBinding {
     UNABBREVIATE("Unabbreviate", Localization.lang("Unabbreviate"), "ctrl+alt+shift+A", KeyBindingCategory.TOOLS),
     UNDO("Undo", Localization.lang("Undo"), "ctrl+Z", KeyBindingCategory.EDIT),
     WEB_SEARCH("Web search", Localization.lang("Web search"), "alt+4", KeyBindingCategory.SEARCH),
-    WRITE_XMP("Write XMP", Localization.lang("Write XMP"), "F6", KeyBindingCategory.TOOLS),
+    WRITE_METADATA_TO_PDF("Write metadata to PDF files", Localization.lang("Write metadata to PDF files"), "F6", KeyBindingCategory.TOOLS),
     CLEAR_SEARCH("Clear search", Localization.lang("Clear search"), "ESCAPE", KeyBindingCategory.SEARCH),
     CLEAR_READ_STATUS("Clear read status", Localization.lang("Clear read status"), "", KeyBindingCategory.EDIT),
     READ("Set read status to read", Localization.lang("Set read status to read"), "", KeyBindingCategory.EDIT),

src/main/java/org/jabref/logic/exporter/EmbeddedBibFilePdfExporter.java

@@ -64,7 +64,7 @@ public void export(BibDatabaseContext databaseContext, Path file, Charset encodi
     }
 
     private void embedBibTex(String bibTeX, Path file, Charset encoding) throws IOException {
-        if (!Files.exists(file) || !StandardFileType.PDF.getExtensions().contains(FileUtil.getFileExtension(file).orElse(""))) {
+        if (!Files.exists(file) || !FileUtil.isPDFFile(file)) {
             return;
         }
         try (PDDocument document = PDDocument.load(file.toFile())) {
@@ -80,7 +80,15 @@ private void embedBibTex(String bibTeX, Path file, Charset encoding) throws IOEx
                 document.getDocumentCatalog().setNames(nameDictionary);
             } else {
                 efTree = nameDictionary.getEmbeddedFiles();
+                if (efTree == null) {
+                    efTree = new PDEmbeddedFilesNameTreeNode();
+                    nameDictionary.setEmbeddedFiles(efTree);
+                }
                 names = efTree.getNames();
+                if (names == null) {
+                    names = new HashMap<>();
+                    efTree.setNames(names);
+                }
             }
 
             if (efTree != null) {

src/main/resources/l10n/JabRef_en.properties

@@ -908,14 +908,13 @@ web\ link=web link
 What\ do\ you\ want\ to\ do?=What do you want to do?
 Whatever\ option\ you\ choose,\ Mr.\ DLib\ may\ share\ its\ data\ with\ research\ partners\ to\ further\ improve\ recommendation\ quality\ as\ part\ of\ a\ 'living\ lab'.\ Mr.\ DLib\ may\ also\ release\ public\ datasets\ that\ may\ contain\ anonymized\ information\ about\ you\ and\ the\ recommendations\ (sensitive\ information\ such\ as\ metadata\ of\ your\ articles\ will\ be\ anonymised\ through\ e.g.\ hashing).\ Research\ partners\ are\ obliged\ to\ adhere\ to\ the\ same\ strict\ data\ protection\ policy\ as\ Mr.\ DLib.=Whatever option you choose, Mr. DLib may share its data with research partners to further improve recommendation quality as part of a 'living lab'. Mr. DLib may also release public datasets that may contain anonymized information about you and the recommendations (sensitive information such as metadata of your articles will be anonymised through e.g. hashing). Research partners are obliged to adhere to the same strict data protection policy as Mr. DLib.
 
-Will\ write\ XMP\ metadata\ to\ the\ PDFs\ linked\ from\ selected\ entries.=Will write XMP metadata to the PDFs linked from selected entries.
+Will\ write\ metadata\ to\ the\ PDFs\ linked\ from\ selected\ entries.=Will write metadata to the PDFs linked from selected entries.
 
 Write\ BibTeXEntry\ as\ metadata\ to\ PDF.=Write BibTeXEntry as metadata to PDF.
 Write\ metadata\ for\ all\ PDFs\ in\ current\ library?=Write metadata for all PDFs in current library?
 Writing\ metadata\ for\ selected\ entries...=Writing metadata for selected entries...
 Writing\ metadata...=Writing metadata...
 
-Write\ XMP=Write XMP
 Embed\ BibTeXEntry\ in\ PDF.=Embed BibTeXEntry in PDF.
 Write\ BibTeXEntry\ as\ XMP\ metadata\ to\ PDF.=Write BibTeXEntry as XMP metadata to PDF.
 Write\ BibTeXEntry\ metadata\ to\ PDF.=Write BibTeXEntry metadata to PDF.
@@ -1869,7 +1868,6 @@ Set\ up\ general\ fields=Set up general fields
 View\ change\ log=View change log
 View\ event\ log=View event log
 Website=Website
-Write\ XMP\ metadata\ to\ PDFs=Write XMP metadata to PDFs
 
 Override\ default\ font\ settings=Override default font settings
 Clear\ search=Clear search