Code

Refactor Sidepane logic#8202

Code

Merged

Siedlerchr merged 37 commits intoJabRef:mainJabRef/jabref:mainfrom HoussemNasri:refactor-sidepaneCopy head branch name to clipboardDec 14, 2021

+622-555

Commits

Commits on Oct 30, 2021

• Add visibleProperty to SidePaneComponent

  HoussemNasri

  committed
  13fc122

Commits on Oct 31, 2021

• Making progress into refactoring Sidepane logic

  Show description for 9688ec6
  HoussemNasri

  committed
  9688ec6

• Populate SidePaneType with information

  HoussemNasri

  committed
  e7ddff6

• Wrap the content of web search side pane into WebSearchPaneView

  HoussemNasri

  committed
  eee68e7

• Revert changes to SidePane

  HoussemNasri

  committed
  9c3a314

• Refactor SidePaneContainer

  Show description for f59bb3f
  HoussemNasri

  committed
  f59bb3f

• Bind side pane check menu selection state to side pane visibility

  HoussemNasri

  committed
  41dba61

• Fix checkstyle

  HoussemNasri

  committed
  c839950

• Remove SidePaneViewModel.java

  HoussemNasri

  committed
  69c90df

• Fix view menu for sidebar option out of sync with sidebar state

  Show description for a9e0419
  HoussemNasri

  committed
  a9e0419

• Remove unused constructor parameters

  HoussemNasri

  committed
  289165b

• Remove deprecated Sidepane component

  HoussemNasri

  committed
  d807d9b

Commits on Nov 1, 2021

• Move Vbox.setVgrow() to SidePaneView

  HoussemNasri

  committed
  971203a

• Merge SidePaneHeaderView into SidePaneView

  HoussemNasri

  committed
  2266a67

Commits on Nov 2, 2021

• Avoid firing removed and added events on ObservableList

  Show description for 8224cc5
  HoussemNasri

  committed
  8224cc5

• Use shorter more declarative code for binding

  HoussemNasri

  committed
  5a877ab

Commits on Nov 6, 2021

• Rename SidePaneView to SidePaneComponent and SidePaneContainerView to SidePane

  HoussemNasri

  committed
  1d35778

• Rename initView() to initialize()

  HoussemNasri

  committed
  6d9d52d

• Add an overloading of createCheckMenuItem() with a selected property

  HoussemNasri

  committed
  2f0590d

• Rename sidePaneVisibleProperty() to paneVisibleProperty()

  HoussemNasri

  committed
  58edb1c

• Use the name pane rather than sidePane to call components in the SidePane

  HoussemNasri

  committed
  7e70c25

• Remove unused method createSidePaneCheckMenuItem()

  HoussemNasri

  committed
  9cd8894

• Share the visibility property of side pane components by moving it to StateManager

  HoussemNasri

  committed
  7176862

• Remove comment

  HoussemNasri

  committed
  b0cae97

• Use better names

  HoussemNasri

  committed
  85308f7

• Fix checkstyle

  HoussemNasri

  committed
  e44ae48

Commits on Nov 8, 2021

• Move close/toggle pane actions to separate files

  HoussemNasri

  committed
  2616335

Commits on Nov 14, 2021

• Move sidepane binding logic to SidePaneViewModel

  HoussemNasri

  committed
  ab49960

Commits on Dec 1, 2021

• Merge remote-tracking branch 'upstream/main' into refactor-sidepane

  calixtus

  committed
  e2141bc

Commits on Dec 5, 2021

• Removed unnecessary properties in stateManager, refactored to mvvm pattern

  calixtus

  committed
  e573811

• Moved listener from sidepane visibility property to list of children in sidepane

  calixtus

  committed
  2149f6c

Commits on Dec 6, 2021

• Removed unused method

  calixtus

  committed
  e74403c

Commits on Dec 11, 2021

• Fixed sidepane width issue on startup

  calixtus

  committed
  531dafc

• Created tests

  calixtus

  committed
  1b56325

• Cleanups

  calixtus

  committed
  9af0d79

• CHANGELOG.md

  calixtus

  committed
  ecfb529

• more CHANGELOG.md

  calixtus

  committed
  2ff238b