Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArXiVIdentifier -- dot is required and not arbitrary character #8149

Merged
merged 6 commits into from
Oct 17, 2021

Conversation

koppor
Copy link
Member

@koppor koppor commented Oct 14, 2021

In #8129 @colinhex found out that we have a parsing error in org.jabref.model.entry.identifier.ArXivIdentifier. ArXiV requires a . (dot) and not an arbitrary character. See https://arxiv.org/help/arxiv_identifier.

This PR fixes it.

Moreover, I identified that Eprint is a semantic duplicate of ArXivIdentifier. The former was implemented by @stefan-kolb on 2017-03-09, the latter by @tobiasdiez on 2017-01-15. I removed Eprint and integrated the tests in ArXivIdentifierTest. I also fixed some minor issues in ArXivIdentifier.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor mentioned this pull request Oct 14, 2021
5 tasks
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, good that you spotted the duplication in the Eprint and Arxiv identifier.

@Siedlerchr
Copy link
Member

A fetcher test is failing:


  org.opentest4j.AssertionFailedError: Expected org.jabref.logic.importer.FetcherException to be thrown, but nothing was thrown.
      at app//org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:71)
      at app//org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:37)
      at app//org.junit.jupiter.api.Assertions.assertThrows(Assertions.java:3082)
      at app//org.jabref.logic.importer.fetcher.ArXivTest.searchWithMalformedIdThrowsException(ArXivTest.java:226)

Example:

Caused by: java.io.IOException: Server returned HTTP response code: 500 for URL: eprint.iacr.org/eprint-bin/cite.pl?entry=2017/1118
@koppor
Copy link
Member Author

koppor commented Oct 17, 2021

Tests failing, because IEEE is down:

grafik

Example link: https://ieeexplore.ieee.org/document/4279612

@koppor
Copy link
Member Author

koppor commented Oct 17, 2021

checkstyle should be fixed by #8154

@Siedlerchr Siedlerchr merged commit eea27ab into main Oct 17, 2021
@Siedlerchr Siedlerchr deleted the fixArxivIdParsing branch October 17, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants