-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snap: Use lzo compression & switch to core20 base #8109
Conversation
LZO compression speeds up cold starts tremendously while increasing the download size a moderate amount. Also switch to core20 and its more recent gnome extension.
Thanks a lot for your PR! LGTM and sounds reasonable. Just a question, does core-20 work on machines that do not yet use Ubuntu 20.x? |
Yes, that is the case. core20 ships a minimal Ubuntu 20.04 to decouple the snap from the host. As snaps also run on other distributions, such a dependency wouldn't make sense anyway. Proof: root@suited-feline:~# cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=18.04
DISTRIB_CODENAME=bionic
DISTRIB_DESCRIPTION="Ubuntu 18.04.6 LTS"
root@suited-feline:~# grep base /snap/syncthing-arubislander/current/meta/snap.yaml
base: core20
root@suited-feline:~# syncthing-arubislander.syncthing --help
Usage: syncthing <command>
Flags:
-h, --help Show context-sensitive help.
Commands:
serve
Run Syncthing
decrypt <path>
Decrypt or verify an encrypted folder
cli
Command line interface for Syncthing
Run "syncthing <command> --help" for more information on a command. |
Thanks for the clarification! Next edge build should pick this up |
Thanks for providing a snap in the first place. If only the file dialogs used the xdg desktop portal, the experience would be absolutely flawless. But unfortunately that's stuff buried in JavaFX (they use GtkFileChooserDialog instead of GtkFileChooserNative). |
@ppd We also ship self-containing deb and rpm files. One of our goal once was to provide a newer JabRef version native to debian repos or so, but that turns out to be soo complicated with all those dependencies. So I do think snap and flatpak are some valid alternatives.
Yeah that file opening/opening folders seems to be always tricky under linux with the different desktop environments (e.g. #8093 |
I have just refreshed to |
LZO compression speeds up cold starts tremendously while
increasing the download size a moderate amount.
Also switch to core20 and its more recent gnome extension.
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)