Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: Use lzo compression & switch to core20 base #8109

Merged
merged 2 commits into from
Sep 30, 2021

Conversation

ppd
Copy link
Contributor

@ppd ppd commented Sep 30, 2021

LZO compression speeds up cold starts tremendously while
increasing the download size a moderate amount.

Also switch to core20 and its more recent gnome extension.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

ppd added 2 commits September 30, 2021 18:12
LZO compression speeds up cold starts tremendously while
increasing the download size a moderate amount.

Also switch to core20 and its more recent gnome extension.
@Siedlerchr
Copy link
Member

Thanks a lot for your PR! LGTM and sounds reasonable. Just a question, does core-20 work on machines that do not yet use Ubuntu 20.x?

@ppd
Copy link
Contributor Author

ppd commented Sep 30, 2021

Just a question, does core-20 work on machines that do not yet use Ubuntu 20.x?

Yes, that is the case. core20 ships a minimal Ubuntu 20.04 to decouple the snap from the host. As snaps also run on other distributions, such a dependency wouldn't make sense anyway.

Proof:

root@suited-feline:~# cat /etc/lsb-release 
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=18.04
DISTRIB_CODENAME=bionic
DISTRIB_DESCRIPTION="Ubuntu 18.04.6 LTS"
root@suited-feline:~# grep base /snap/syncthing-arubislander/current/meta/snap.yaml 
base: core20      
root@suited-feline:~# syncthing-arubislander.syncthing --help
Usage: syncthing <command>

Flags:
  -h, --help    Show context-sensitive help.

Commands:
  serve
    Run Syncthing

  decrypt <path>
    Decrypt or verify an encrypted folder

  cli
    Command line interface for Syncthing

Run "syncthing <command> --help" for more information on a command.

@Siedlerchr
Copy link
Member

Siedlerchr commented Sep 30, 2021

Thanks for the clarification! Next edge build should pick this up

@Siedlerchr Siedlerchr merged commit b9e50b9 into JabRef:main Sep 30, 2021
@ppd ppd deleted the update-snap branch September 30, 2021 18:01
@ppd
Copy link
Contributor Author

ppd commented Sep 30, 2021

Thanks for providing a snap in the first place. If only the file dialogs used the xdg desktop portal, the experience would be absolutely flawless. But unfortunately that's stuff buried in JavaFX (they use GtkFileChooserDialog instead of GtkFileChooserNative).

@Siedlerchr
Copy link
Member

@ppd We also ship self-containing deb and rpm files. One of our goal once was to provide a newer JabRef version native to debian repos or so, but that turns out to be soo complicated with all those dependencies. So I do think snap and flatpak are some valid alternatives.

if only the file dialogs used the xdg desktop portal, the experience would be absolutely flawless. But unfortunately that's stuff buried in JavaFX (they use GtkFileChooserDialog instead of GtkFileChooserNative).

Yeah that file opening/opening folders seems to be always tricky under linux with the different desktop environments (e.g. #8093

@ppd
Copy link
Contributor Author

ppd commented Oct 1, 2021

Next edge build should pick this up

I have just refreshed to edge revision 1282, and everything looks fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants