Implement an interface to import PDF metadata from multiple sources (XMP, Grobid, ...)

CHANGELOG.md

@@ -17,6 +17,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
 - We added unprotect_terms to the list of bracketed pattern modifiers [#7826](https://github.com/JabRef/jabref/pull/7960)
 - We added a dialog that allows to parse metadata from linked pdfs. [#7929](https://github.com/JabRef/jabref/pull/7929)
 - We added an icon picker in group edit dialog. [#6142](https://github.com/JabRef/jabref/issues/6142)
+- We added a preference to Opt-In to Grobid usage. [8002](https://github.com/JabRef/jabref/pull/8002)
 
 ### Changed
 

src/main/java/org/jabref/gui/entryeditor/EntryEditor.java

@@ -8,6 +8,7 @@
 import java.util.Objects;
 import java.util.Optional;
 import java.util.Set;
+import java.util.SortedSet;
 import java.util.stream.Collectors;
 
 import javax.inject.Inject;
@@ -357,13 +358,25 @@ private void setupToolBar() {
 
         // Add menu for fetching bibliographic information
         ContextMenu fetcherMenu = new ContextMenu();
-        for (EntryBasedFetcher fetcher : WebFetchers.getEntryBasedFetchers(preferencesService.getImportSettingsPreferences(), preferencesService.getImportFormatPreferences(), preferencesService.getFilePreferences(), databaseContext, preferencesService.getDefaultEncoding())) {
+        SortedSet<EntryBasedFetcher> entryBasedFetchers = WebFetchers.getEntryBasedFetchers(
+                preferencesService.getImportSettingsPreferences(),
+                preferencesService.getImportFormatPreferences(),
+                preferencesService.getFilePreferences(),
+                databaseContext,
+                preferencesService.getDefaultEncoding());
+        for (EntryBasedFetcher fetcher : entryBasedFetchers) {
             MenuItem fetcherMenuItem = new MenuItem(fetcher.getName());
             if (fetcher instanceof PdfMergeMetadataImporter.EntryBasedFetcherWrapper) {
                 // Handle Grobid Opt-In in case of the PdfMergeMetadataImporter
                 fetcherMenuItem.setOnAction(event -> {
                     GrobidOptInDialogHelper.showAndWaitIfUserIsUndecided(dialogService);
-                    PdfMergeMetadataImporter.EntryBasedFetcherWrapper pdfMergeMetadataImporter = new PdfMergeMetadataImporter.EntryBasedFetcherWrapper(preferencesService.getImportSettingsPreferences(), preferencesService.getImportFormatPreferences(), preferencesService.getFilePreferences(), databaseContext, preferencesService.getDefaultEncoding());
+                    PdfMergeMetadataImporter.EntryBasedFetcherWrapper pdfMergeMetadataImporter =
+                            new PdfMergeMetadataImporter.EntryBasedFetcherWrapper(
+                                    preferencesService.getImportSettingsPreferences(),
+                                    preferencesService.getImportFormatPreferences(),
+                                    preferencesService.getFilePreferences(),
+                                    databaseContext,
+                                    preferencesService.getDefaultEncoding());
                     fetchAndMerge(pdfMergeMetadataImporter);
                 });
             } else {

src/main/java/org/jabref/gui/externalfiles/ImportHandler.java

@@ -57,7 +57,10 @@ public ImportHandler(BibDatabaseContext database,
         this.stateManager = stateManager;
 
         this.linker = new ExternalFilesEntryLinker(externalFileTypes, preferencesService.getFilePreferences(), database);
-        this.contentImporter = new ExternalFilesContentImporter(preferencesService.getImportSettingsPreferences(), preferencesService.getImportFormatPreferences(), preferencesService.getTimestampPreferences());
+        this.contentImporter = new ExternalFilesContentImporter(
+                preferencesService.getImportSettingsPreferences(),
+                preferencesService.getImportFormatPreferences(),
+                preferencesService.getTimestampPreferences());
         this.undoManager = undoManager;
     }
 

src/test/java/org/jabref/logic/importer/util/GrobidServiceTest.java

@@ -75,7 +75,8 @@ public void processInvalidCitationTest() {
 
     @Test
     public void failsWhenGrobidDisabled() {
-        assertThrows(UnsupportedOperationException.class, () -> new GrobidService(new ImportSettingsPreferences(false, false, false, "http://grobid.jabref.org:8070")));
+        ImportSettingsPreferences importSettingsWithGrobidDisabled = importSettingsPreferences.withGrobidEnabled(false);
+        assertThrows(UnsupportedOperationException.class, () -> new GrobidService(importSettingsWithGrobidDisabled));
     }
 
     @Test