Abbreviation toggle within the JournalEditorViewModel now ignores curly braces (issue #7773) #7807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…java to ignore curly braces when matching (Issue JabRef#7773).
Siedlerchr
requested changes
Jun 8, 2021
Siedlerchr
approved these changes
Jun 9, 2021
Siedlerchr
added
the
status: ready-for-review
btut
suggested changes
Jun 11, 2021
btut
approved these changes
Jun 14, 2021
calixtus
requested changes
Jun 14, 2021
CHANGELOG.md
Outdated
| @@ -41,6 +41,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve | |||
| - We reintroduced missing default keybindings for new entries. [#7346](https://github.com/JabRef/jabref/issues/7346) [#7439](https://github.com/JabRef/jabref/issues/7439) | |||
| - Lists of available fields are now sorted alphabetically. [#7716](https://github.com/JabRef/jabref/issues/7716) | |||
| - We moved the select/collapse buttons in the unlinked files dialog into a context menu. [#7383](https://github.com/JabRef/jabref/issues/7383) | |||
| - We changed the abbreviation toggle within the JournalEditorViewModel.java to ignore curly braces when matching. [#7773](https://github.com/JabRef/jabref/issues/7773) | |||
There was a problem hiding this comment.
Please try to omit technical documentation in the changelog. The changelog is user-focused and should describe what changes are visible for the end user. Please reword.
calixtus
added
the
status: changes required
Siedlerchr
reviewed
Jun 17, 2021
|
Thanks for your contribution! I just adjusted the changelog a bit |
Siedlerchr
added a commit
that referenced
this pull request
Jun 22, 2021
* upstream/main: New Crowdin updates (#7843) Refactoring and addition of unit tests (#7597) CLI option to write XMP metadata to pdfs (#7814) Add query validation for web search (#7809) change eclipse default output dir (#7842) Bump lucene-queryparser from 8.8.2 to 8.9.0 (#7835) Bump libreoffice from 7.1.3 to 7.1.4 (#7836) Bump postgresql from 42.2.21 to 42.2.22 (#7839) Bump org.eclipse.jgit (#7838) Bump byte-buddy-parent from 1.11.2 to 1.11.5 (#7837) Bump unoloader from 7.1.3 to 7.1.4 (#7841) Ms Office Export patent author as inventor (#7831) Abbreviation toggle within the JournalEditorViewModel now ignores curly braces (issue #7773) (#7807)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed the abbreviation toggle (shown in the entry editor for the journal field) in JournalEditorViewModel to ignore curly braces when matching.
The field text is stripped of any left or right curly braces before it is passed to isKnownName() and getNextAbbreviation().
Fixes #7773.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)