Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an icon picker in group edit dialog for issue#6142 #7758

Closed
wants to merge 6 commits into from

Conversation

EricLee543
Copy link

@EricLee543 EricLee543 commented May 20, 2021

For issue #6142 , I add an icon picker in group edit dialog.
There are two ways to select an icon. First, select an icon by icon picker button. Second, input icon name in iconfield. This dialog is implemented by ScrollPane and Pagination. Here is a demo video.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.
IconPIckerVideo.1.mov

@EricLee543 EricLee543 changed the title Create icon dialog Add an icon picker in group edit dialog for issue#6142 May 20, 2021
@calixtus
Copy link
Member

Hi @EricLee543 on first sight, this looks like a really cool idea, I did not yet look into the code though.
One idea to improve the UI in the group dialog: Maybe it is possible to unify the button icon picker and the text field into something combobox-like field and add a graphic node to the text displaying the selected icon in the text field.
Thanks for your work!

@Siedlerchr
Copy link
Member

Please have a look at the checkstyle/reviewdog stuff

@Siedlerchr Siedlerchr added the status: changes required Pull requests that are not yet complete label May 24, 2021
@calixtus calixtus mentioned this pull request Jun 3, 2021
5 tasks
@koppor
Copy link
Member

koppor commented Jun 3, 2021

@ericlee Welcome to JabRef development.

The first thing to learn about open-source-projects is that developers have limited time resources. They rely on automatation.

Did you see our automated tools?

grafik

Following is accessible via: https://github.com/JabRef/jabref/pull/7758/files

grafik

Is this part of a university course? If yes, based on our long experiences, I see the following things: Your supervisor seem not to have contacted us in advanced (see https://devdocs.jabref.org/teaching for details). Thus, I have to ask you whether you intend to work on this PR for the next weeks?

@EricLee543 EricLee543 closed this Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: changes required Pull requests that are not yet complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants