Add simple unit tests #7696
Merged
Add simple unit tests #7696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add elemental test case for formatters, to check that a valid input remains unmodified.
koppor
requested changes
May 3, 2021
| @@ -29,6 +29,12 @@ void extractURLFormLink() { | |||
| formatter.format("away.php?to=http%3A%2F%2Fwikipedia.org&a=snippet")); | |||
| } | |||
|
|
|||
| @Test | |||
| void validURLUnmodified() { | |||
| // the caller has to pay attention that this does not happen | |||
There was a problem hiding this comment.
What should not happen? Maybe just remove the comment.
The call seems IMHO legal.
There was a problem hiding this comment.
That's on me, I copy-pasted and forgot to remove it.
| @@ -29,6 +29,12 @@ void extractURLFormLink() { | |||
| formatter.format("away.php?to=http%3A%2F%2Fwikipedia.org&a=snippet")); | |||
| } | |||
|
|
|||
| @Test | |||
| void validURLUnmodified() { | |||
There was a problem hiding this comment.
We try to gradually migrate to Google's casing rules: https://google.github.io/styleguide/javaguide.html#s5.3-camel-case
Thus, please introduce defined camel case
Suggested change
| void validURLUnmodified() { | |
| void validUrlUnmodified() { |
| @@ -19,6 +19,7 @@ public void setUp() { | |||
|
|
|||
| @Test | |||
| public void test() { | |||
| assertEquals("lower", formatter.format("lower")); | |||
There was a problem hiding this comment.
Could you maybe change that to a paramterized test? We aim for having one assertion per test case. See also #6207
Address the requested changes from #7696
|
I addressed the requested changes in the last commit, should be all good now. |
Siedlerchr
approved these changes
May 13, 2021
Siedlerchr
added a commit
that referenced
this pull request
May 15, 2021
* upstream/main: (71 commits) [Bot] Update CSL styles (#7735) Fix for issue 6966: open all files of multiple entries (#7709) Add simple unit tests (#7696) Add simple unit tests (#7543) Update check-outdated-dependencies.yml Added preset for new entry keybindings and reintroduced defaults (#7705) Select the entry which has smaller dictonary order when merge (#7708) Update CHANGELOG.md fix: make more fields, fomatters, ids and languages sorted by alphabetical order (#7717) Bump libreoffice from 7.1.2 to 7.1.3 (#7721) Bump unoloader from 7.1.2 to 7.1.3 (#7724) Bump org.beryx.jlink from 2.23.7 to 2.23.8 (#7723) Bump org.openjfx.javafxplugin from 0.0.9 to 0.0.10 (#7725) fix: make fields sorted by lexicographical order (#7711) Fix tests Refactoring existing unit tests (#7687) Refactoring and addition of unit tests (#7581) Refactor simple Unit Tests (#7571) Add simple unit tests (#7544) add and extend unit tests (#7685) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contributes to issue #6207, which is to add more unit tests or improve existing ones.
I added the trivial, but important, test case, that the output should remain unmodified in case the input was already valid.
Tests extended:
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)