Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zbmath fetcher #7440

Merged
merged 20 commits into from
Feb 15, 2021
Merged

Zbmath fetcher #7440

merged 20 commits into from
Feb 15, 2021

Conversation

ibe-314
Copy link
Contributor

@ibe-314 ibe-314 commented Feb 9, 2021 •
edited by Siedlerchr
Loading

Add zbmath to the public databases which can be chosen when updating an entry with bibliographic information from the web. See Fixes #7437.

Screenshot (3)

Screenshot (4)

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

ibe-314 and others added 18 commits January 4, 2021 16:53
@ibe-314
add IdBasedParserFetcher to zbmath fetcher
6b574fa
@ibe-314
add test for id-based zbmath fetcher
5395567
@ibe-314
Merge remote-tracking branch 'upstream/master' into adjust-zbmath-fet…
29890bc 
…cher
@ibe-314
Add changes to CHANGELOG.md
b865624
@ibe-314
fix zbmath fetcher test
3a67513
@ibe-314
Merge remote-tracking branch 'upstream/master' into adjust-zbmath-fet…
81eac0e 
…cher
@ibe-314
Made changelog message more understandable
a68f12f
@ibe-314
Merge pull request #1 from ibe-314/adjust-zbmath-fetcher
e575e90 
Adjust zbmath fetcher
@ibe-314
implement entry based fetcher for zbmath
91a6b30
@ibe-314
Syncing fork with upstream/master.
e4190d5
@ibe-314
Merge branch 'local_branch'
8ffac33
@ibe-314
handle case that no zbmath entry is found and add tests
e6fcb41
@ibe-314
remove console output
418be6b
@ibe-314
change tests for zbmathfetcher
9cdc736
@ibe-314
fix zbmath fetcher test
317864d
@ibe-314
remove unused import
2c62701
@ibe-314
Merge remote-tracking branch 'upstream/master' into zbmathFetcher
2091fc5
@ibe-314
Add changes to CHANGELOG
84f4a8d
@ibe-314
Copy link
Contributor Author

ibe-314 commented Feb 10, 2021

In the Fetcher Tests src/test/java/org/jabref/logic/importer/fetcher/ZbMATHTest.java did not fail but some tests for other fetchers. I think this failures are not due to my changes.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 11, 2021
tobiasdiez
tobiasdiez requested changes Feb 12, 2021
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution. This is a nice feature!

I have a few remarks, but they are only minor once.

src/main/java/org/jabref/logic/importer/EntryBasedParserFetcher.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/importer/EntryBasedParserFetcher.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/importer/fetcher/ZbMATH.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/logic/importer/fetcher/ZbMATH.java Show resolved Hide resolved
src/test/java/org/jabref/logic/importer/fetcher/ZbMATHTest.java Outdated Show resolved Hide resolved
src/test/java/org/jabref/logic/importer/fetcher/ZbMATHTest.java Outdated Show resolved Hide resolved
src/test/java/org/jabref/logic/importer/fetcher/ZbMATHTest.java Show resolved Hide resolved
src/test/java/org/jabref/logic/importer/fetcher/ZbMATHTest.java Outdated Show resolved Hide resolved
@ibe-314
Copy link
Contributor Author

ibe-314 commented Feb 13, 2021 •
edited
Loading

Thank You for the help with the AuthorList Class.
I added the requested changes. Three fetcher Tests from other fetchers failed but not from the zbmath fetcher.

tobiasdiez
tobiasdiez approved these changes Feb 14, 2021
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the quick follow-up. The code looks good to me.

Just out of interest, are you affiliated in some way with zentralblatt?

@ibe-314
Copy link
Contributor Author

ibe-314 commented Feb 14, 2021

I work for them ;-) I wrote this sometime ago on gitter...but you might not follow all messages there.

@Siedlerchr Siedlerchr merged commit f26e25b into JabRef:master Feb 15, 2021
Siedlerchr added a commit that referenced this pull request Feb 21, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into ikonlimaterial
a92c889 
* upstream/master:
  Bump pascalgn/automerge-action from v0.13.0 to v0.13.1 (#7445)
  Auto-approve depend-a-bot-PRs (#7332)
  Clarify that changelog is user-facing
  Remove unmaintained AUTHORS file
  Fixes the issue "Non valid number as font size results in an uncaught exception." (#7438)
  Zbmath fetcher (#7440)
  Bump me.champeau.gradle.jmh from 0.5.2 to 0.5.3 (#7444)
  Bump styfle/cancel-workflow-action from 0.7.0 to 0.8.0 (#7446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance bibliographic information with data from zbmath.org
3 participants
@ibe-314 @tobiasdiez @Siedlerchr