-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add special fields ADR #7300
Add special fields ADR #7300
Conversation
Co-authored-by: Oliver Kopp <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
What was our timeline for the migration? Do we have an open issue for this?
* Good, because can be easily removed (e.g., by a formatter) | ||
* Good, because prepares future power of JabRef to make field properties configurable | ||
* Bad, because bloats BibTeX file (see below) | ||
* Bad, because requires more timing (see below) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by timing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo --> fixed to "Bad, because requires more writing when editing BibTeX manually by hand"
### Special fields as sub-feature of groups | ||
|
||
* Good, because one concept rulez them all | ||
* Good, because groups already have special handling for author names |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the connection to author names?
Finally, after months after JabCon 😅
The migration itself is (IMHO) the linked issue #6840 with Milestone v5.3 We already have the default to not do any synchronization (released with v5.2). --> #6846 At #JabCon we also noted down following next steps:
We don't have issues for that - should I add some? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation!
…dtask * upstream/master: Adjust zbmath fetcher (#7298) Add "acm-siggraph.csl" required by CitationStyle.java Added Keyboard shortcuts (clear/set read status) (#7302) Add special fields ADR (#7300) Overwrite local copies Squashed 'buildres/csl/csl-locales/' content from commit ecb8e70233 Squashed 'buildres/csl/csl-styles/' content from commit 737ffa1 Adapt workflow and build.gradle Move CSL to buildres/csl to speedup "processResources" during development
* upstream/master: (34 commits) Fixed exception about missing custom css file (#7292) Update the templates for opening a new issue (#7321) Entitlements file Mac (#7317) Make CONTRIBUTING.md much shorter. Move long text to docs/contributing.md (#7293) Include Github-optimized screenshot into repository (#7318) Remove obsolete registry patch file (#7316) Fix AUTHORS GitBook: [master] one page modified Remove broken Sonarqube integration (#7315) GitBook: [master] 5 pages and 32 assets modified docs: update license year (#7314) Add javafx version number + update javafx (#7312) Add missing authors Adjust zbmath fetcher (#7298) Add "acm-siggraph.csl" required by CitationStyle.java Added Keyboard shortcuts (clear/set read status) (#7302) Add special fields ADR (#7300) Overwrite local copies Squashed 'buildres/csl/csl-locales/' content from commit ecb8e70233 Squashed 'buildres/csl/csl-styles/' content from commit 737ffa1 ...
As input for #6840
This writes down the ADR for special fields discussed at #JabCon.
Result: We have special fields as "normal" BibTeX key/value fields. We do not have synchronization of keywords any more.
Documentation: This will obsolete the last paragraph at https://docs.jabref.org/finding-sorting-and-cleaning-entries/specialfields#configuration-of-the-storage-mode-in-the-library.
For the brave: The ADR can be edited using the UI available at https://github.com/koppor/adr-manager/.